Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport v4.x] querystring: don't stringify bad surrogate pair #6125

Closed
wants to merge 1 commit into from
Closed

[backport v4.x] querystring: don't stringify bad surrogate pair #6125

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Apr 8, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • querystring
Description of change

Fixes: #3702

@mscdex
querystring: don't stringify bad surrogate pair
7bf8bd0 
Fixes: nodejs#3702
PR-URL: nodejs#5858
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex mscdex added querystring Issues and PRs related to the built-in querystring module. v4.x labels Apr 8, 2016
@mscdex mscdex changed the title querystring: don't stringify bad surrogate pair [backport v4.x] querystring: don't stringify bad surrogate pair Apr 8, 2016
@jasnell
Copy link
Member

jasnell commented Apr 9, 2016

Rubber stamp LGTM if CI is green

@mscdex
Copy link
Contributor Author

mscdex commented Apr 9, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2229/

@MylesBorins
Copy link
Contributor

ci is green LGTM

@MylesBorins
Copy link
Contributor

landed in 65fc4e3

@mscdex mscdex deleted the backport-v4.x-querystring-throw-urierror branch December 14, 2016 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
querystring Issues and PRs related to the built-in querystring module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mscdex @jasnell @MylesBorins