-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msi: Add WM_SETTINGCHANGE broadcast on InstallFinalize #613
Conversation
lgtm, I'll make sure this gets in a nightly later today, I'll merge if @piscisaureus doesn't first |
Looks good enough for now, let's get this into a nightly and then a release. I want to see if this fixes the issue. For later reference, there are some things I'd do to reduce this patch
|
I've reduced the patch a little: https://github.com/piscisaureus/io.js/compare/msi-broadcast-setting-change. |
@piscisaureus Did you test the patch? It compiles but the msi prompts with an error |
I reduced the patch according to your hints. But I left the DLL export with the DEF file. |
given the big diff between these two proposals I'm not going to step in and merge this, will leave it to @piscisaureus to merge something and then we'll get that into a nightly |
|
Sure, as you want. I only chose that name because most of the WIX extensions are in camelcase.
Oh, never noticed my incomplete github profile. Update is out ;) |
In theory the msi should broadcast a 'WM_SETTINGCHANGE' message to all windows after modifying the PATH environment variable. This ensures that the new PATH is visible to other processes without restarting windows (although it's still necessary to close and reopen active console windows). Unfortunately, the broadcast doesn't always happen, for unknown reasons. That's why this patch adds a custom action that unconditionally broadcasts a WM_SETTINGCHANGE message. Bug: nodejs#603 PR: nodejs#613 Reviewed-by: Bert Belder <bertbelder@gmail.com>
@mathiask88 |
Landed in 668bde8. @mathiask88 Thanks for your help! |
Backport 668bde8 from io.js. Original commit message follows: In theory the msi should broadcast a 'WM_SETTINGCHANGE' message to all windows after modifying the PATH environment variable. This ensures that the new PATH is visible to other processes without restarting windows (although it's still necessary to close and reopen active console windows). Unfortunately, the broadcast doesn't always happen, for unknown reasons. That's why this patch adds a custom action that unconditionally broadcasts a WM_SETTINGCHANGE message. Bug: nodejs/node#603 PR: nodejs/node#613 Reviewed-by: Bert Belder <bertbelder@gmail.com> (cherry picked from commit 668bde8) --Node.js commmit metadata-- PR-URL: #25100 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Fixes: #4356
Backport 668bde8 from io.js. Original commit message follows: In theory the msi should broadcast a 'WM_SETTINGCHANGE' message to all windows after modifying the PATH environment variable. This ensures that the new PATH is visible to other processes without restarting windows (although it's still necessary to close and reopen active console windows). Unfortunately, the broadcast doesn't always happen, for unknown reasons. That's why this patch adds a custom action that unconditionally broadcasts a WM_SETTINGCHANGE message. Bug: nodejs/node#603 PR: nodejs/node#613 Reviewed-by: Bert Belder <bertbelder@gmail.com> (cherry picked from commit 668bde8) --Node.js commmit metadata-- PR-URL: nodejs#25100 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Fixes: nodejs#4356
Backport 668bde8 from io.js. Original commit message follows: In theory the msi should broadcast a 'WM_SETTINGCHANGE' message to all windows after modifying the PATH environment variable. This ensures that the new PATH is visible to other processes without restarting windows (although it's still necessary to close and reopen active console windows). Unfortunately, the broadcast doesn't always happen, for unknown reasons. That's why this patch adds a custom action that unconditionally broadcasts a WM_SETTINGCHANGE message. Bug: nodejs/node#603 PR: nodejs/node#613 Reviewed-by: Bert Belder <bertbelder@gmail.com> (cherry picked from commit 668bde8) --Node.js commmit metadata-- PR-URL: nodejs#25100 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Fixes: nodejs#4356
When i build io.js with vs 2013, get error message:
|
I think that's unrelated. IO.js is normally built with vs2013 which (obviously) works. |
I used wix 3.8, not find the wcautil.h. Update to 3.9, the file existed. I will retry. |
@JacksonTian See nodejs/node-v0.x-archive#25569 for the description of a similar issue in joyent/node, and a work in progress to make such failures easier to troubleshoot. |
Backport 668bde8 from io.js. Original commit message follows: In theory the msi should broadcast a 'WM_SETTINGCHANGE' message to all windows after modifying the PATH environment variable. This ensures that the new PATH is visible to other processes without restarting windows (although it's still necessary to close and reopen active console windows). Unfortunately, the broadcast doesn't always happen, for unknown reasons. That's why this patch adds a custom action that unconditionally broadcasts a WM_SETTINGCHANGE message. Bug: nodejs/node#603 PR: nodejs/node#613 Reviewed-by: Bert Belder <bertbelder@gmail.com> (cherry picked from commit 668bde8) --Node.js commmit metadata-- PR-URL: nodejs#25100 Reviewed-By: Julien Gilli <julien.gilli@joyent.com> Fixes: nodejs#4356
Fix: #603