v6.0.0 Release Candidate 4 #6155

jasnell · 2016-04-11T20:35:18Z

This is the PR for the release candidate.

PLEASE DO NOT LAND THIS PR

It is here for review and CI purposes only.

/cc @nodejs/ctc

jasnell · 2016-04-11T20:36:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/2241/

cjihrig · 2016-04-11T20:55:28Z

@jasnell the list of semver majors is not comprehensive. Is that intentional? Shouldn't all of them at least be mentioned in the changelog?

jasnell · 2016-04-11T20:58:35Z

I pulled out some of the "lesser" ones from the notable changes. The
commits are currently only since v5.10.1. I still have to go in and add the
full list of the semver-majors to that list.
On Apr 11, 2016 1:55 PM, "Colin Ihrig" notifications@github.com wrote:

@jasnell https://github.com/jasnell the list of semver majors is not
comprehensive. Is that intentional? Shouldn't all of them at least be
mentioned in the changelog?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6155 (comment)

jasnell · 2016-04-11T23:30:09Z

Release Candidate Build: https://ci-release.nodejs.org/job/iojs+release/503/

jbergstroem · 2016-04-12T03:34:23Z

(the 32-bit slave's java process crashed)

mscdex · 2016-04-12T03:54:54Z

It's a conspiracy, Java will stop at nothing to prevent node v6 from being released!

jasnell · 2016-04-12T04:02:12Z

Well, we at least got a partial rc.1 build: https://nodejs.org/download/rc/v6.0.0-rc.1/

jasnell · 2016-04-12T04:05:26Z

I'll do a RC.2 on wednesday. Time to start the testing!

MylesBorins · 2016-04-12T04:13:33Z

@jasnell a quick test shows the the .pkg installer is working as expected. npm install works, and installing a gyp compiled module (heapdump) does as well

This was all manually tested on osx 10.10.5

fhemberger · 2016-04-12T04:55:03Z

Can we ship localized Windows and OS X installers with 6.0? First one is already on hold since io.js v3 ;)

vsemozhetbyt · 2016-04-12T07:59:50Z

v8 is still 4.9 in the RC1. Will it be 5.0 in the release or another RC?

jasnell · 2016-04-12T08:02:57Z

@vsemozhetbyt ... that is the hope. I decided to hold off building RC.1 with v5 until we're a bit closer to v5 going stable. The plan is to try our absolute best to get v5 in.

vsemozhetbyt · 2016-04-12T08:10:08Z

@jasnell Thank you. It will be greate, with its RegEx Unicode support and performance improvements.

orangemocha · 2016-04-12T10:15:58Z

CHANGELOG.md

+* Windows
+  * Windows XP and Vista are no longer supported
+    [#5167](https://github.com/nodejs/node/pull/5167),
+    [#5167](https://github.com/nodejs/node/pull/5167).


Duplicate link

dnalborczyk · 2016-04-14T16:41:45Z

@jasnell

Chrome 50.0.2661.75 went stable: http://googlechromereleases.blogspot.com/2016/04/stable-channel-update_13.html and so should be V8 5.0.71.32, according to Dominic's gist: https://gist.github.com/domenic/aca7774a5d94156bfcc1 and https://omahaproxy.appspot.com/

Daniel

jasnell · 2016-04-14T17:49:40Z

Rebased for RC 2. Initial CI: https://ci.nodejs.org/job/node-test-pull-request/2261/

jasnell · 2016-04-14T17:50:31Z

Note: I HAVE NOT yet updated the change log in this. I will do so before cutting the actual updated release candidate.

MylesBorins · 2016-04-14T21:17:10Z

CI looks good. The two arm failures are unrelated (flaky)

jasnell · 2016-04-15T02:51:02Z

Release Candidate 2 Build: https://ci-release.nodejs.org/job/iojs+release/514/
Build failure on Rpi -> https://ci-release.nodejs.org/job/iojs+release/nodes=pi1-raspbian-wheezy/514/

jasnell · 2016-04-15T03:43:32Z

Release Candidate 2 builds with v8 v5 are ready to go... https://nodejs.org/download/rc/v6.0.0-rc.2/

vsemozhetbyt · 2016-04-15T07:53:02Z

node-v6.0.0-rc.2-x64.msi creates link to docs as
https://nodejs.org/download/custom/v6.0.0-rc.2/docs/api/ ("404: Page could not be found")
instead of
https://nodejs.org/download/rc/v6.0.0-rc.2/docs/api/ (OK).

jasnell · 2016-04-15T07:54:34Z

Ok, that's due to me missing a step in the CI job that sets the url base. Will be fixed in RC3 next week.

Salakar · 2016-04-15T13:25:03Z

@jasnell have there been any regressions to module.js / require?

See: Salakar/mocha@7c07b67

Works fine on v5.10.1

jasnell · 2016-04-15T13:26:26Z

@vsemozhetbyt ... we have one regression currently being looked at here: #6215 , likely the cause

jasnell · 2016-04-15T20:25:39Z

That's a question for v8 folks /cc @ofrobots

dnalborczyk · 2016-04-15T21:07:25Z

@vsemozhetbyt The flag might be just a leftover. A search for the 'harmony_regexp_property' flag in the node/v8-project-code reveals no usage.

It seems it should work without a flag in v8 5.0:
http://v8project.blogspot.com/2016/03/v8-release-50.html

vsemozhetbyt · 2016-04-15T21:36:57Z

@dnalborczyk The http://v8project.blogspot.com/2016/03/v8-release-50.html supposes this flag:

  --harmony_unicode_regexps (enable "harmony unicode regexps")
        type: bool  default: true

— i.e. the u regexp flag, the \u{xxxxx} symbols and unicode semantics of quantifiers and . class. It seems to have nothing to do with property classes (\p{} symbols) under the different flag (--harmony_regexp_property).

dnalborczyk · 2016-04-15T22:12:05Z

My bad. I only glanced over the blog post. Nonetheless, the flag is not being used, there's no condition using it whatsoever (unless my search is broken).

Maybe the flag was forgotten or it wasn't feasible to use it?

vsemozhetbyt · 2016-04-15T22:31:25Z

@dnalborczyk Then why node --v8-options on the Node v6 RC2 has it in the output? And why the feature that is not a part of any standart or even draft works just like that (while in the last Crome Canary it does not)? This is a great feature and I like it a lot (I've missed it since the Perl RegExp), but it seems a bit strange.

ofrobots · 2016-04-16T00:27:33Z

@vsemozhetbyt I suspect this is a V8 issue – I can reproduce it with Chrome 50 – I have opened an upstream bug.

rvagg · 2016-04-16T10:55:59Z

@nodejs/collaborators FYI nightlies are back on, they took a bit of a break after we moved the Jenkins release job to a more secure instance but they should be running again and coming out at https://nodejs.org/download/nightly/

There are currently v5.x (currently 5.10.2-nightly...) and master (currently 6.0.0-nightly...) nightlies. The 5.x ones will only appear if folks are cherry picking from master to v5.x, there have been a couple of us doing this in the past but it's not been very regular. If those who are regularly releasing off v5.x could make a regular habit of cherry picking eligible commits then we will get more regular nightlies. The master nightlies will switch to 7.0.0-nightly... after we make the v6 release and I'll also turn off nightlies for v5.x and turn on v6.x.

The master nightlies should be good for testing v6.0.0 if you're on that effort. node-gyp understands these so in theory the should be drop-in replacements to whatever you're using now.

jasnell · 2016-04-16T13:07:05Z

Woo! Yeah I got all excited yesterday when I saw a nightly build had been
kicked off. Great to see.
On Apr 16, 2016 3:56 AM, "Rod Vagg" notifications@github.com wrote:

@nodejs/collaborators https://github.com/orgs/nodejs/teams/collaborators
FYI nightlies are back on, they took a bit of a break after we moved the
Jenkins release job to a more secure instance but they should be
running again and coming out at https://nodejs.org/download/nightly/

There are currently v5.x (currently 5.10.2-nightly...) and master
(currently 6.0.0-nightly...) nightlies. The 5.x ones will only appear if
folks are cherry picking from master to v5.x, there have been a couple of
us doing this in the past but it's not been very regular. If those who are
regularly releasing off v5.x could make a regular habit of cherry picking
eligible commits then we will get more regular nightlies. The master
nightlies will switch to 7.0.0-nightly... after we make the v6 release and
I'll also turn off nightlies for v5.x and turn on v6.x.

The master nightlies should be good for testing v6.0.0 if you're on that
effort. node-gyp understands these so in theory the should be drop-in
replacements to whatever you're using now.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6155 (comment)

dnalborczyk · 2016-04-16T13:21:27Z

@vsemozhetbyt
Then why node --v8-options on the Node v6 RC2 has it in the output?

The parameters are just being passed on from node to the v8 engine. Node itself doesn't provide nor handle them.

And why the feature that is not a part of any standart or even draft works just like that

You might have to ask that question the v8 project. Not sure about any drafts or proposals. The commit message in one of the links you provided says: [regexp] experimental implementation for \p property class.

dnalborczyk · 2016-04-16T13:34:10Z

@jasnell @rvagg

I asked myself the following already in the past, but always forgot to follow up:

I'm wondering if the RC releases are announced and accessible anywhere, besides buried in github issues and pull requests. I can't find any mention on the node website. How would anyone be able to test the RC, if the majority doesn't even know about its existence?

jasnell · 2016-04-16T15:44:14Z

They're announced on Twitter, that's about it. We could definitely do more
to get the word out tho. A blog post on the website would likely be a good
start.
On Apr 16, 2016 6:34 AM, "dnalborczyk" notifications@github.com wrote:

@jasnell https://github.com/jasnell @rvagg https://github.com/rvagg

I asked myself the following already in the past, but always forgot to
follow up:

I'm wondering if the RC releases are announced and accessible anywhere,
besides buried in github issues and pull requests. I can't find any mention
on the node website https://nodejs.org. How would anyone be able to
test the RC, if the majority doesn't even know about it's existence?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6155 (comment)

vsemozhetbyt · 2016-04-16T16:18:21Z

@jasnell Could you give the twitter link please?

benjamingr · 2016-04-16T16:44:26Z

Sorry if unrelated - and this might be a silly thing to ask - but why should collaborators care about nightlies? Whenever I want to test something I just build the source off the branch and run it (which I need to be able to do as a collaborator anyway).

I think it could be interesting to get people to run v6 before the release and provide useful feedback and bug reports. That might be a @nodejs/evangelism issue though.

hashseed · 2016-04-19T08:46:08Z

This is simply a bug in V8's 5.0 branch. It's already fixed in 5.1 and 5.2. I'll fix this. Related V8 issue: https://bugs.chromium.org/p/v8/issues/detail?id=4926

hashseed · 2016-04-19T09:24:24Z

Fixed in V8 version 5.0.71.33.

jasnell · 2016-04-19T21:41:10Z

Release Candidate 3 build running now: https://ci-release.nodejs.org/job/iojs+release/532/

mdouglass · 2016-04-19T23:20:47Z

Can't run our projects with rc3 because of mocha being broken by #6215. Will that be being merged before release?

jasnell · 2016-04-19T23:23:11Z

@mdouglass ... hopefully should land in the next day or two. Definitely in time for the release next week

jasnell · 2016-04-22T19:24:12Z

Release candidate 4 build: https://ci-release.nodejs.org/job/iojs+release/545/
(this includes #6215 btw)

mdouglass · 2016-04-22T19:34:47Z

Excellent, I'll give it a try now.

jasnell · 2016-04-22T19:40:03Z

Give it a few more minutes to finish building :-) ... likely about 10-20 at the max

jasnell · 2016-04-26T00:27:59Z

Continuing work here: #6383

jasnell added the wip Issues and PRs that are still a work in progress. label Apr 11, 2016

mscdex added the meta Issues and PRs related to the general management of the project. label Apr 11, 2016

jasnell force-pushed the v6-rc1 branch from 6d56acb to d2c4b77 Compare April 11, 2016 23:25

orangemocha reviewed Apr 12, 2016
View reviewed changes

jasnell force-pushed the v6-rc1 branch from d2c4b77 to f3956b7 Compare April 14, 2016 17:48

jasnell changed the title ~~v6.0.0 Release Candidate 1~~ v6.0.0 Release Candidate 2 Apr 14, 2016

jasnell force-pushed the v6-rc1 branch from f3956b7 to 17b6c2c Compare April 15, 2016 02:46

ChALkeR mentioned this pull request Apr 17, 2016

harmony-regexp-properties should be not enabled without a flag yet #6251

Closed

jasnell force-pushed the v6-rc1 branch from 17b6c2c to 59bc4db Compare April 19, 2016 21:34

jasnell changed the title ~~v6.0.0 Release Candidate 2~~ v6.0.0 Release Candidate 3 Apr 19, 2016

2016-04-22, Version 6.0.0 (Release Candidate)

26fa665

jasnell force-pushed the v6-rc1 branch from 59bc4db to 26fa665 Compare April 22, 2016 19:20

jasnell changed the title ~~v6.0.0 Release Candidate 3~~ v6.0.0 Release Candidate 4 Apr 22, 2016

jasnell closed this Apr 26, 2016

refack mentioned this pull request May 25, 2017

6.0.0-rc.0 release does not include source tarball nodejs/help#636

Closed

v6.0.0 Release Candidate 4 #6155

v6.0.0 Release Candidate 4 #6155

Conversation

jasnell commented Apr 11, 2016

jasnell commented Apr 11, 2016

cjihrig commented Apr 11, 2016

jasnell commented Apr 11, 2016

jasnell commented Apr 11, 2016

jbergstroem commented Apr 12, 2016

mscdex commented Apr 12, 2016

jasnell commented Apr 12, 2016

jasnell commented Apr 12, 2016

MylesBorins commented Apr 12, 2016

fhemberger commented Apr 12, 2016

vsemozhetbyt commented Apr 12, 2016

jasnell commented Apr 12, 2016

vsemozhetbyt commented Apr 12, 2016

orangemocha Apr 12, 2016

Choose a reason for hiding this comment

dnalborczyk commented Apr 14, 2016

jasnell commented Apr 14, 2016

jasnell commented Apr 14, 2016

MylesBorins commented Apr 14, 2016 • edited Loading

jasnell commented Apr 15, 2016 • edited Loading

jasnell commented Apr 15, 2016

vsemozhetbyt commented Apr 15, 2016

jasnell commented Apr 15, 2016

Salakar commented Apr 15, 2016 • edited Loading

jasnell commented Apr 15, 2016

jasnell commented Apr 15, 2016

dnalborczyk commented Apr 15, 2016

vsemozhetbyt commented Apr 15, 2016

dnalborczyk commented Apr 15, 2016

vsemozhetbyt commented Apr 15, 2016 • edited Loading

ofrobots commented Apr 16, 2016

rvagg commented Apr 16, 2016

jasnell commented Apr 16, 2016

dnalborczyk commented Apr 16, 2016 • edited Loading

dnalborczyk commented Apr 16, 2016 • edited Loading

jasnell commented Apr 16, 2016

vsemozhetbyt commented Apr 16, 2016

benjamingr commented Apr 16, 2016

hashseed commented Apr 19, 2016

hashseed commented Apr 19, 2016

jasnell commented Apr 19, 2016

mdouglass commented Apr 19, 2016

jasnell commented Apr 19, 2016

jasnell commented Apr 22, 2016

mdouglass commented Apr 22, 2016

jasnell commented Apr 22, 2016

jasnell commented Apr 26, 2016

MylesBorins commented Apr 14, 2016 •

edited

Loading

jasnell commented Apr 15, 2016 •

edited

Loading

Salakar commented Apr 15, 2016 •

edited

Loading

vsemozhetbyt commented Apr 15, 2016 •

edited

Loading

dnalborczyk commented Apr 16, 2016 •

edited

Loading

dnalborczyk commented Apr 16, 2016 •

edited

Loading