Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: don't set non-primitive values on templates #6228

Merged
merged 1 commit into from
Apr 18, 2016
Merged

src: don't set non-primitive values on templates #6228

merged 1 commit into from
Apr 18, 2016

Commits on Apr 18, 2016

  1. src: don't set non-primitive values on templates 

    V8 is going to disallow non-primitive values on v8::FunctionTemplate
and v8::ObjectTemplate because those can't be shared across contexts.

Fixes: nodejs#6216
PR-URL: nodejs#6228
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Apr 18, 2016
    Configuration menu
    Copy the full SHA
    642076f View commit details
    Browse the repository at this point in the history