deps: exclude tests on ppc for v8 5.0 #6267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 issues which either the v8 team was reluctant to backport the fix because the fix was for a disabled feature (wasm) or that we did not have time to investigate before 5.0 was cut which result in v8 test failures for PPC in 5.0. These are test issues and are already resolved in v8 master. This PR excludes these tests so that our v8 tests in the CI will be green so that we can detect any real regressions.
|
LGTM |
mscdex
added
test
|
LGTM |
1 similar comment
|
LGTM |
|
CI clean except for timeout on arm and we seem to see those regularly. Also no link between the failure and this change. Going to land. |
mhdawson
added a commit
that referenced
this pull request
Apr 20, 2016
There were 2 issues which either the v8 team was reluctant to backport the fix because the fix was for a disabled feature (wasm) or that we did not have time to investigate before 5.0 was cut which result in v8 test failures for PPC in 5.0. These are test issues and are already resolved in v8 master. This PR excludes these tests so that our v8 tests in the CI will be green so that we can detect any real regressions. PR-URL: #6267 Fixes: #6236 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed as 0899ea7. |
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
There were 2 issues which either the v8 team was reluctant to backport the fix because the fix was for a disabled feature (wasm) or that we did not have time to investigate before 5.0 was cut which result in v8 test failures for PPC in 5.0. These are test issues and are already resolved in v8 master. This PR excludes these tests so that our v8 tests in the CI will be green so that we can detect any real regressions. PR-URL: nodejs#6267 Fixes: nodejs#6236 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
There were 2 issues which either the v8 team was reluctant to backport the fix because the fix was for a disabled feature (wasm) or that we did not have time to investigate before 5.0 was cut which result in v8 test failures for PPC in 5.0. These are test issues and are already resolved in v8 master. This PR excludes these tests so that our v8 tests in the CI will be green so that we can detect any real regressions. PR-URL: #6267 Fixes: #6236 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
deps/v8
Description of change
Addresses: #6236
There were 2 issues which either the v8 team was reluctant to
backport the fix because the fix was for a disabled feature (wasm) or
that we did not have time to investigate before 5.0 was cut
which result in v8 test failures for PPC in 5.0. These are test
issues and are already resolved in v8 master. This PR
excludes these tests so that our v8 tests in the CI will
be green so that we can detect any real regressions.