v8: warn in Template::Set() on improper use #6277

bnoordhuis · 2016-04-19T14:57:15Z

The next major release will make it a fatal error to use non-primitive
values in function templates and object templates.

Print a warning that includes the C and JS stack trace to tell people to
upgrade their add-ons. The C stack trace is only printed on platforms
that support it (the BSDs, OS X and Linux+glibc.)

Refs: #6216

Speculative - I'd like some input whether other collaborators think it's a good approach. It can get pretty noisy when native code abuses v8::Template::Set() a lot but OTOH, hopefully that means it gets fixed quickly.

CI: https://ci.nodejs.org/job/node-test-pull-request/2319/

jasnell · 2016-04-19T15:15:05Z

This LGTM ~~but I'm curious how difficult it would be to have native code level warnings like this make use of the JS-level process.emitWarning() mechanism.~~ .. nevermind! sigh, this is in the v8 code lol.

thefourtheye · 2016-04-19T15:35:14Z

deps/v8/src/api.cc

@@ -939,6 +939,15 @@ void Template::Set(v8::Local<Name> name, v8::Local<Data> value,
  i::Isolate* isolate = templ->GetIsolate();
  ENTER_V8(isolate);
  i::HandleScope scope(isolate);
+  auto value_obj = Utils::OpenHandle(*value);


Do we need to leave a to-do here?

I can add a TODO but what should it say?

Perhaps TODO: Throw Error instead of warning in v7.0?

Oh, it's not going to throw; newer V8 versions replace it with a CHECK that aborts when it fails.

Oh I see. This is the change which you initially had in #6228, right? This? Then, we may not need a TODO I think. Eventually v8 upgrades will take care of this.

thefourtheye · 2016-04-19T15:37:03Z

Don't we use dep: as the subsystem? Apart from that LGTM.

bnoordhuis · 2016-04-19T15:49:42Z

Don't we use dep: as the subsystem?

It's a bit of both. Historically, v8: was used for floating patches; deps: for upgrades. I can change it to deps: warn in v8::Template::Set() on improper use if that's preferred.

thefourtheye · 2016-04-19T16:04:55Z

Historically, v8: was used for floating patches; deps: for upgrades

Oh, I didn't notice that before. Then we can leave it as it is.

bnoordhuis · 2016-04-19T16:12:24Z

I forgot, cc @nodejs/v8 @jeisinger.

ofrobots · 2016-04-19T16:57:59Z

I wonder if it makes sense to add a flag (upstream, and floated here) to silence such runtime deprecation warnings. I do think it is good to be noisy by default on such imminent deprecations, but it would also be nice to be able to silence the warning if the user wishes.

One the problems native modules have had is that they never realize that things have been deprecated for a long time, and discover it when next Node.js major w/ new V8 drop them. If such a runtime deprecation warning flag existed, we could potentially use it for more things.

bnoordhuis · 2016-04-19T19:57:49Z

I'd be okay with adding a flag but I assume that also calls for some kind of framework inside V8 for logging deprecation notices? Input on what that should look like appreciated; or if you're willing to take that on, I'm happy to step aside.

jasnell · 2016-04-21T03:23:05Z

@ofrobots ... well, we do already have a flags for handling deprecations and warnings in node of course. Perhaps it would be possible to provide an API for embedders that would allow handling of the runtime deprecations/warnings to be deferred to the embedder? We could then insert our own logic and control the output using the existing --no-deprecation|--trace-deprecation|--throw-deprecation|--no-warnings|--trace-warnings mechanisms.

jasnell · 2016-04-21T03:23:53Z

Of more immediate concern, however, is whether this particular PR can land as is for v6 or does it need to be tweaked some more?

bnoordhuis · 2016-04-21T06:40:57Z

If it needs a complete overhaul, then it's not going to be ready for v6.0.0, which would be a shame, IMO.

I can add a flag to deps/v8/src/flag-definitions.h that silences the warning. Suggestions on the name?

ofrobots · 2016-04-21T06:50:58Z

Given that this is urgent for v6, deciding on the framework before then might not be feasible, I agree.

How about something specific for this case for now; specially if we are not pushing it upstream first? Perhaps [no_]template_set_warning?

bnoordhuis · 2016-04-21T07:41:26Z

Sounds good, that's more or less what I had in mind. I'll update the PR later today.

bnoordhuis · 2016-04-22T21:10:16Z

Updated, PTAL. CI: https://ci.nodejs.org/job/node-test-pull-request/2369/

jasnell · 2016-04-22T21:20:15Z

LGTM if CI is green

The next major release will make it a fatal error to use non-primitive values in function templates and object templates. Print a warning that includes the C and JS stack trace to tell people to upgrade their add-ons. The C stack trace is only printed on platforms that support it (the BSDs, OS X and Linux+glibc.) The warning can be disabled with the new `--nowarn_template_set` flag. Refs: nodejs#6216 PR-URL: nodejs#6277 Reviewed-By: James M Snell <jasnell@gmail.com>

The next major release will make it a fatal error to use non-primitive values in function templates and object templates. Print a warning that includes the C and JS stack trace to tell people to upgrade their add-ons. The C stack trace is only printed on platforms that support it (the BSDs, OS X and Linux+glibc.) The warning can be disabled with the new `--nowarn_template_set` flag. Refs: #6216 PR-URL: #6277 Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins · 2016-06-01T23:34:04Z

@bnoordhuis looks like this is specific to v8 > 5
Set dont-land... please modify if I am incorrect

The next major release will make it a fatal error to use non-primitive values in function templates and object templates. Print a warning that includes the C and JS stack trace to tell people to upgrade their add-ons. The C stack trace is only printed on platforms that support it (the BSDs, OS X and Linux+glibc.) The warning can be disabled with the new `--nowarn_template_set` flag. Refs: nodejs#6216 PR-URL: nodejs#6277 Reviewed-By: James M Snell <jasnell@gmail.com>

bnoordhuis added the v8 engine Issues and PRs related to the V8 dependency. label Apr 19, 2016

bnoordhuis added this to the 6.0.0 milestone Apr 19, 2016

thefourtheye reviewed Apr 19, 2016
View reviewed changes

ofrobots mentioned this pull request Apr 21, 2016

Planning for v6 #5766

Closed

bnoordhuis force-pushed the template-set-warning branch from 467b4b8 to 50b35aa Compare April 22, 2016 21:09

bnoordhuis force-pushed the template-set-warning branch from 50b35aa to 7940ecf Compare April 22, 2016 21:51

bnoordhuis closed this Apr 22, 2016

bnoordhuis deleted the template-set-warning branch April 22, 2016 21:51

bnoordhuis merged commit 7940ecf into nodejs:master Apr 22, 2016

ofrobots mentioned this pull request Apr 26, 2016

Using deprecated APIs in node v6 fsevents/fsevents#127

Closed

xzyfer mentioned this pull request Apr 27, 2016

Node 6: Failed at the node-sass@3.6.0 postinstall script 'node scripts/build.js' sass/node-sass#1484

Closed

olalonde mentioned this pull request Apr 28, 2016

Error with Node v6.0.0? remy/nodemon#824

Closed

jbcpollak mentioned this pull request May 1, 2016

deprecation warnings when used with node v6.0.0 chrisa/node-dtrace-provider#74

Closed

JCMais mentioned this pull request May 11, 2016

node 6.x: Warning on Template::Set() improper usage JCMais/node-libcurl#61

Closed

MylesBorins added the dont-land-on-v4.x label Jun 1, 2016

evanlucas mentioned this pull request Aug 26, 2016

2016-08-26, Version 6.5.0 (Current) #8253

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v8: warn in Template::Set() on improper use #6277

v8: warn in Template::Set() on improper use #6277

bnoordhuis commented Apr 19, 2016 •

edited

Loading

jasnell commented Apr 19, 2016 •

edited

Loading

thefourtheye Apr 19, 2016

bnoordhuis Apr 19, 2016

thefourtheye Apr 19, 2016

bnoordhuis Apr 19, 2016

thefourtheye Apr 19, 2016

thefourtheye commented Apr 19, 2016

bnoordhuis commented Apr 19, 2016

thefourtheye commented Apr 19, 2016

bnoordhuis commented Apr 19, 2016

ofrobots commented Apr 19, 2016

bnoordhuis commented Apr 19, 2016

jasnell commented Apr 21, 2016

jasnell commented Apr 21, 2016

bnoordhuis commented Apr 21, 2016

ofrobots commented Apr 21, 2016

bnoordhuis commented Apr 21, 2016

bnoordhuis commented Apr 22, 2016

jasnell commented Apr 22, 2016

MylesBorins commented Jun 1, 2016

v8: warn in Template::Set() on improper use #6277

v8: warn in Template::Set() on improper use #6277

Conversation

bnoordhuis commented Apr 19, 2016 • edited Loading

jasnell commented Apr 19, 2016 • edited Loading

thefourtheye Apr 19, 2016

Choose a reason for hiding this comment

bnoordhuis Apr 19, 2016

Choose a reason for hiding this comment

thefourtheye Apr 19, 2016

Choose a reason for hiding this comment

bnoordhuis Apr 19, 2016

Choose a reason for hiding this comment

thefourtheye Apr 19, 2016

Choose a reason for hiding this comment

thefourtheye commented Apr 19, 2016

bnoordhuis commented Apr 19, 2016

thefourtheye commented Apr 19, 2016

bnoordhuis commented Apr 19, 2016

ofrobots commented Apr 19, 2016

bnoordhuis commented Apr 19, 2016

jasnell commented Apr 21, 2016

jasnell commented Apr 21, 2016

bnoordhuis commented Apr 21, 2016

ofrobots commented Apr 21, 2016

bnoordhuis commented Apr 21, 2016

bnoordhuis commented Apr 22, 2016

jasnell commented Apr 22, 2016

MylesBorins commented Jun 1, 2016

bnoordhuis commented Apr 19, 2016 •

edited

Loading

jasnell commented Apr 19, 2016 •

edited

Loading