test: fix test-vm-cached-data to work with old v8 #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
added
vm
|
hmm... not sure there's enough value at this point with v6 right around the corner. If we were going to pull this back to v4 then I think I'd be +1 for sure. |
|
@jasnell I figured we would probably not want it... but had already made the patch and it was small enough I figured we might want to be explicit |
|
this would need to be rebased now ;-) |
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
7da4fd4
to
c7066fb
Compare
MylesBorins
force-pushed
the
fix-vm-cached-data
branch
from
9388716
to
2af4e57
Compare
|
@jasnell rebased |
|
LGTM but can you capitalize 'while' and use 'Refs:' in the commit log? |
|
LGTM, but may be we should just turn the only |
MylesBorins
force-pushed
the
fix-vm-cached-data
branch
2 times, most recently
from
e70f2cc
to
43166c0
Compare
|
I've updated with both of your suggestions @bnoordhuis / @indutny PTAL and let me know if this is ok |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
MylesBorins
force-pushed
the
fix-vm-cached-data
branch
from
43166c0
to
e26f1e7
Compare
While `let` no longer needs to run in `strict mode` in v8 5.x it throws in v8 4. This modification will make the test-vm-cached-data work in older version of node. Refs: nodejs#6280 PR-URL: nodejs#6317 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins
force-pushed
the
fix-vm-cached-data
branch
from
e26f1e7
to
9460b20
Compare
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
While `let` no longer needs to run in `strict mode` in v8 5.x it throws in v8 4. This modification will make the test-vm-cached-data work in older version of node. Refs: #6280 PR-URL: #6317 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while
letno longer needs to run instrict modein v8 5.x it throwsin v8 4. This modification will make the test-vm-cached-data work in
older version of node.
I am under the impression that these changes were made to test features that will only be available in v8 5. So perhaps we don't care to support older versions. Either way it might be nice to be explicit with the code being shelled out.
I've currently marked #6280 as
dont-land-on-v5.x, but we can change that if this lands/cc @jasnell @indutny