deps: upgrade to V8 5.0.71.34 #6320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pick up the latest bug fix from the V8 5.0 branch. Original commit message: V8-Commit: v8/v8@c36773f Version 5.0.71.34 (cherry-pick) Merged 9acbca1 [es6] Fix bug in pattern re-writing BUG=v8:4891 LOG=N R=littledan@chromium.org Review URL: https://codereview.chromium.org/1906633002 .
Closed
|
LGTM pending CI |
|
LGTM |
1 similar comment
|
LGTM |
|
@ofrobots ... want to go ahead and get this landed today? I might take some time this afternoon to put together a v6 RC.4 |
|
test-regress-GH-5727 on ARM seems to be a machine/network related issue. I will go ahead and land this. |
|
@ofrobots that test has been fixed since the time you started your CI run, so it's safe to ignore. |
|
Thanks. Landed as 49e42c5. |
ofrobots
added a commit
that referenced
this pull request
Apr 21, 2016
Pick up the latest bug fix from the V8 5.0 branch. Original commit message: V8-Commit: v8/v8@c36773f Version 5.0.71.34 (cherry-pick) Merged 9acbca1 [es6] Fix bug in pattern re-writing BUG=v8:4891 LOG=N R=littledan@chromium.org Review URL: https://codereview.chromium.org/1906633002 . PR-URL: #6320 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
Pick up the latest bug fix from the V8 5.0 branch. Original commit message: V8-Commit: v8/v8@c36773f Version 5.0.71.34 (cherry-pick) Merged 9acbca1 [es6] Fix bug in pattern re-writing BUG=v8:4891 LOG=N R=littledan@chromium.org Review URL: https://codereview.chromium.org/1906633002 . PR-URL: nodejs#6320 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
Pick up the latest bug fix from the V8 5.0 branch. Original commit message: V8-Commit: v8/v8@c36773f Version 5.0.71.34 (cherry-pick) Merged 9acbca1 [es6] Fix bug in pattern re-writing BUG=v8:4891 LOG=N R=littledan@chromium.org Review URL: https://codereview.chromium.org/1906633002 . PR-URL: #6320 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Pick up the latest bug fix from the V8 5.0 branch.
Original commit message:
V8-Commit: v8/v8@c36773f
R=@nodejs/v8
/cc @jasnell
CI: https://ci.nodejs.org/job/node-test-pull-request/2350/