test,tools: limit lint tolerance of gc global

[Trott]

Checklist

• tests and code linting passes
• the commit message follows commit guidelines

Affected core subsystem(s)

test tools

Description of change

Lint rules permitted the gc global in any test file. This change
limits it to just the files that need it.

[bnoordhuis]

LGTM, I guess. Would this allow global.gc() without an eslint directive?

[cjihrig]

Would this allow global.gc() without an eslint directive?

It looks like it, based on the change to test/common.js, but I could be wrong.

LGTM

[jasnell]

This is fine and the change LGTM but I'm curious.. why?

[Trott]

@jasnell wrote:

This is fine and the change LGTM but I'm curious.. why?

I prefer exceptions to lint rules to be applied only as narrowly as necessary. So rather than applying an exception to the 1324 JS files in test, this applies that exception to just the dozen or so files that need it.

[Trott]

@bnoordhuis asked:

Would this allow global.gc() without an eslint directive?

Yes, that would pass linting.

[addaleax]

LGTM

[jasnell]

@Trott ... ok :-) thanks!

[bnoordhuis]

Anyone prefer gc() over global.gc() or vice versa? I have a mild preference for the latter because it lets us drop the eslint directive. It's mostly aesthetic though.

[cjihrig]

Dropping the eslint directive is preferably IMO in case things change in the future on their side or ours.

[Trott]

Removed the directives and replaced instances of gc with global.gc. PTAL!

[cjihrig]

LGTM

[bnoordhuis]

LGTM

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/2422/

[Trott]

CI is green except for unrelated and known-problematic tick processor test on OS X which will be fixed Very Soon.

[Trott]

Landed in 6c49714.

[MylesBorins]

not landing cleanly @Trott feel free to tag don't land if you don't want to backport

[bnoordhuis]

@thealphanerd @Trott I think this can land on v4.x once #6871 lands.