Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: exclude tap files from tarballs #6348

Merged
merged 1 commit into from
Apr 28, 2016
Merged

build: exclude tap files from tarballs #6348

merged 1 commit into from
Apr 28, 2016

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Apr 22, 2016

Checklist
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • build
Description of change

This commit excludes generated tap files from tarballs.

@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Apr 22, 2016
@mscdex mscdex force-pushed the build-exclude-tap-from-tarballs branch from 6e97c92 to 389edbd Compare April 22, 2016 14:26
@jasnell
Copy link
Member

jasnell commented Apr 22, 2016

LGTM

1 similar comment
@JungMinu
Copy link
Member

LGTM

@jbergstroem
Copy link
Member

jbergstroem commented Apr 24, 2016 •
edited
Loading

How about *.tap? Regardless LGTM.

Edit: rationale being we might have lint.tap, etc.

@Fishrock123
Copy link
Contributor

lgtm

@mscdex
build: exclude tap files from tarballs
be54989 
PR-URL: nodejs#6348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@mscdex mscdex force-pushed the build-exclude-tap-from-tarballs branch from 389edbd to be54989 Compare April 28, 2016 15:28
@mscdex mscdex merged commit be54989 into nodejs:master Apr 28, 2016
@mscdex mscdex deleted the build-exclude-tap-from-tarballs branch April 28, 2016 15:34
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
@mscdex @Fishrock123
build: exclude tap files from tarballs
8956432 
PR-URL: #6348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced May 4, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mscdex @jasnell @JungMinu @jbergstroem @Fishrock123 @MylesBorins