Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add ronkorving to collaborators #6385

Closed
wants to merge 1 commit into from
Closed

doc: add ronkorving to collaborators #6385

wants to merge 1 commit into from

Conversation

ronkorving
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added myself as a collaborator following the onboarding process with @Trott

@ronkorving ronkorving added the doc Issues and PRs related to the documentations. label Apr 26, 2016
@evanlucas
Copy link
Contributor

Yay. LGTM

@jbergstroem
Copy link
Member

LGTM and welcome 🎉

@ronkorving
Copy link
Contributor Author

Thanks guys :)
Testing CI access through https://ci.nodejs.org/job/node-test-pull-request/2394/

@Trott
Copy link
Member

Trott commented Apr 26, 2016

LGTM. Good to see you!

@ronkorving
Copy link
Contributor Author

Thanks a lot for your time and sharing your wisdom, @Trott :)

@Trott
Copy link
Member

Trott commented Apr 26, 2016

(Before landing, can you confirm that the email address provided in this commit is the same one that are used as the author of your commits?)

@ronkorving
Copy link
Contributor Author

Is the same 👍

ronkorving added a commit that referenced this pull request Apr 26, 2016
@ronkorving
doc: add ronkorving to collaborators
916b1a1 
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #6385
@ronkorving
Copy link
Contributor Author

Landed in 916b1a1

@ronkorving ronkorving closed this Apr 26, 2016
@ronkorving ronkorving deleted the collaborator-update branch April 26, 2016 05:25
@jbergstroem
Copy link
Member

@ronkorving: next time, please put PR-URL on top of metadata. We don't have a strict ruleset for commit messages just now, but 99% of the commits follow at least that guideline.

@Trott
Copy link
Member

Trott commented Apr 26, 2016 •
edited
Loading

@jbergstroem Should we just make it official and add it to the docs, at least as a recommendation/preference?

@evanlucas
Copy link
Contributor

yes please!!

@jbergstroem
Copy link
Member

@Trott: I'm happy to put something together; that way I get what I want 😈

Trott added a commit to Trott/io.js that referenced this pull request Apr 26, 2016
@Trott
doc: note that PR-URL should be first metadata
eb94126 
Convention has coalesced around putting the PR-URL as the first metadata
item in pull requests, so much so that collaborators are now flagging
other collaborators' commit messages when they don't do that. So let's
make it official and document that the PR-URL should be first.

Refs: nodejs/build#325
Refs: nodejs#6385
@Trott Trott mentioned this pull request Apr 26, 2016
Closed
2 tasks
@ronkorving
Copy link
Contributor Author

Yeah, I indeed followed the onboarding doc's bullet list order :) Thanks for the PR @Trott, to make it a bit clearer.

jasnell pushed a commit that referenced this pull request Apr 26, 2016
@ronkorving @jasnell
doc: add ronkorving to collaborators
e45dbd3 
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #6385
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
@ronkorving
doc: add ronkorving to collaborators
aa766a1 
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #6385
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@ronkorving
doc: add ronkorving to collaborators
b112fd1 
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #6385
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@ronkorving
doc: add ronkorving to collaborators
a49c79a 
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #6385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronkorving @evanlucas @jbergstroem @Trott @MylesBorins