-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add estliberitas to collaborators #6386
doc: add estliberitas to collaborators #6386
Conversation
Great to have you on board! LGTM |
LGTM. Welcome! |
Ok, gonna follow all the process and land it, I guess. |
Feel free to force push the amended commit to the same branch if you're unsure about the final commit message; me or someone else'll have a look at it. |
Well, you should do that regardless, but you get the point :) |
PR-URL: #6386 Reviewed-By: Johan Bergström <bugs@bergstroem.nu Reviewed-By: Evan Lucas <evanlucas@me.com>
Landed as d90c42d |
Welcome aboard |
@estliberitas you forgot a closing anchor on my email: |
..and now a missing |
..and now a period? |
PR-URL: #6386 Reviewed-By: Johan Bergström <bugs@bergstroemnu> Reviewed-By: Evan Lucas <evanlucas@me.com>
@jbergstroem Don't get it. |
I fixed it with |
@estliberitas never mind; someone pushed a commit on top of yours anyway. Could perhaps be your |
@estliberitas moving forward, perhaps set and test LC_/locale stuff? |
@jbergstroem yep, doing that |
@estliberitas great! again: happy to see you join :) |
@jbergstroem thanks! |
@jbergstroem ah, |
PR-URL: #6386 Reviewed-By: Johan Bergström <bugs@bergstroemnu> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #6386 Reviewed-By: Johan Bergström <bugs@bergstroem.nu Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #6386 Reviewed-By: Johan Bergström <bugs@bergstroem.nu Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #6386 Reviewed-By: Johan Bergström <bugs@bergstroem.nu Reviewed-By: Evan Lucas <evanlucas@me.com>
Checklist
Affected core subsystem(s)
doc
Description of change
Adding myself (estliberitas)