Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add estliberitas to collaborators #6386

Closed
wants to merge 1 commit into from
Closed

doc: add estliberitas to collaborators #6386

wants to merge 1 commit into from

Conversation

estliberitas
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Adding myself (estliberitas)

@jbergstroem
Copy link
Member

Great to have you on board! LGTM

@Trott
Copy link
Member

Trott commented Apr 26, 2016

LGTM. Welcome!

@estliberitas
Copy link
Contributor Author

Ok, gonna follow all the process and land it, I guess.

@jbergstroem
Copy link
Member

Feel free to force push the amended commit to the same branch if you're unsure about the final commit message; me or someone else'll have a look at it.

@jbergstroem
Copy link
Member

Well, you should do that regardless, but you get the point :)

estliberitas added a commit that referenced this pull request Apr 26, 2016
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroem.nu
Reviewed-By: Evan Lucas <evanlucas@me.com>
@estliberitas
Copy link
Contributor Author

Landed as d90c42d

@evanlucas
Copy link
Contributor

Welcome aboard

@jbergstroem
Copy link
Member

@estliberitas you forgot a closing anchor on my email: Johan Bergström <bugs@bergstroem.nu -- if no one else has merged their commits you have a few minutes to force push to master. Let me know if you're uncomfortable doing so.

@jbergstroem
Copy link
Member

..and now a missing n :)

@jbergstroem
Copy link
Member

..and now a period?

estliberitas added a commit that referenced this pull request Apr 26, 2016
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroemnu>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@estliberitas
Copy link
Contributor Author

@jbergstroem Don't get it.

@estliberitas
Copy link
Contributor Author

I fixed it with git commit --amend then somehow one symbol is always cut

@jbergstroem
Copy link
Member

@estliberitas never mind; someone pushed a commit on top of yours anyway. Could perhaps be your EDITOR not handling ö correctly?

@jbergstroem
Copy link
Member

@estliberitas moving forward, perhaps set and test LC_/locale stuff?

@estliberitas
Copy link
Contributor Author

@jbergstroem yep, doing that

@jbergstroem
Copy link
Member

@estliberitas great! again: happy to see you join :)

@estliberitas
Copy link
Contributor Author

@jbergstroem thanks!

@estliberitas
Copy link
Contributor Author

@jbergstroem ah, LC_* was not set at all. Now it's fixed and no more such problems. 😉

jasnell pushed a commit that referenced this pull request Apr 26, 2016
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroemnu>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroem.nu
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroem.nu
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6386
Reviewed-By: Johan Bergström <bugs@bergstroem.nu
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants