-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add JacksonTian to collaborators #6388
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM - great to have you on board! |
LGTM. Welcome! Might be a good idea to make the commit message meaningful rather than just "Hi!" just to set a good example for others contributing to the project. |
thanks @Trott . |
Added myself as a collaborator following the onboarding process.
JacksonTian
force-pushed
the
collaborator
branch
from
April 26, 2016 05:11
e1b76a5
to
aa19077
Compare
LGTM. Welcome aboard |
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
April 26, 2016 05:23
7da4fd4
to
c7066fb
Compare
LGTM |
JacksonTian
added a commit
that referenced
this pull request
Apr 26, 2016
Added myself as a collaborator following the onboarding process. PR-URL: #6388 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
landed in bf3ffc2 |
JacksonTian
added a commit
that referenced
this pull request
Apr 26, 2016
Added myself as a collaborator following the onboarding process. PR-URL: #6388 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
Added myself as a collaborator following the onboarding process. PR-URL: #6388 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 1, 2016
Added myself as a collaborator following the onboarding process. PR-URL: #6388 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Added myself as a collaborator following the onboarding process. PR-URL: #6388 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Added myself as a collaborator following the onboarding process. PR-URL: #6388 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Added myself as a collaborator following the onboarding process.