Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add eljefedelrodeodeljefe to collaborators #6389

Closed
wants to merge 1 commit into from
Closed

doc: add eljefedelrodeodeljefe to collaborators #6389

wants to merge 1 commit into from

Conversation

eljefedelrodeodeljefe
Copy link
Contributor

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

adds me to the readme.md as collaborator

@ChALkeR
Copy link
Member

ChALkeR commented Apr 26, 2016

LGTM, welcome!

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Apr 26, 2016
@evanlucas
Copy link
Contributor

LGTM. Welcome aboard

@santigimeno
Copy link
Member

LGTM and welcome!

@eljefedelrodeodeljefe
Copy link
Contributor Author

eljefedelrodeodeljefe commented Apr 26, 2016 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/2395/

Gonna merge this after CI :) Thanks guys

eljefedelrodeodeljefe added a commit that referenced this pull request Apr 26, 2016
@eljefedelrodeodeljefe
doc: add eljefedelrodeodeljefe to collaborators
be5d699 
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@eljefedelrodeodeljefe
Copy link
Contributor Author

Landed in be5d699

@eljefedelrodeodeljefe eljefedelrodeodeljefe deleted the doc/add-eljefedelrodeodeljefe-to-collaborators branch April 26, 2016 06:16
@eljefedelrodeodeljefe
Copy link
Contributor Author

With the process in the collaborators guide the PRs won't be marked as merged on GitHub right? Guess it doesn't matter too much.

@Trott
Copy link
Member

Trott commented Apr 26, 2016

@eljefedelrodeodeljefe That's right. @evanlucas told me and others how to make it so that it shows as merged but I don't remember what it was.

@ChALkeR
Copy link
Member

ChALkeR commented Apr 26, 2016 •
edited
Loading

@eljefedelrodeodeljefe @Trott
Trivial — just make sure your branch is rebased on master and push the final commits with all the modifications (including the PR-URL, Reviewed-By, etc) to your branch before landing it to master.

GitHub will label the PR as merged when it sees that all the commits with identical ids are landed on the target branch.

@eljefedelrodeodeljefe
Copy link
Contributor Author

Will try that next time then. Thought I did all that. Thanks

@jbergstroem
Copy link
Member

@ChALkeR we should really add that to the collaborators guide -- it makes it easier to make the assumption that the last commit(s) in the PR was also the one's merged.

@jbergstroem
Copy link
Member

@eljefedelrodeodeljefe you have to force push to your branch since you're rewriting history (git push -f)

@ChALkeR
Copy link
Member

ChALkeR commented Apr 26, 2016

@eljefedelrodeodeljefe The branch had 3f3f41a, the merged commit was be5d699. Those were not identical =).

Update: sorry, copy-pasted wrong commit id. Fixed.

@eljefedelrodeodeljefe
Copy link
Contributor Author

eljefedelrodeodeljefe commented Apr 26, 2016 •
edited
Loading

Yep, after @jbergstroem comments I was realizing that. After adding metadata it needs another force push to the fork.

jasnell pushed a commit that referenced this pull request Apr 26, 2016
@eljefedelrodeodeljefe @jasnell
doc: add eljefedelrodeodeljefe to collaborators
dfc7ffd 
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@eljefedelrodeodeljefe eljefedelrodeodeljefe mentioned this pull request May 19, 2016
Closed
eljefedelrodeodeljefe added a commit that referenced this pull request May 19, 2016
@eljefedelrodeodeljefe
doc: fix name to match git log
ef86953 
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
@eljefedelrodeodeljefe @Fishrock123
doc: fix name to match git log
ee9226e 
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
@eljefedelrodeodeljefe
doc: add eljefedelrodeodeljefe to collaborators
f1314ac 
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@eljefedelrodeodeljefe @rvagg
doc: fix name to match git log
8309dba 
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jun 3, 2016
@eljefedelrodeodeljefe
doc: fix name to match git log
668ef03 
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@eljefedelrodeodeljefe
doc: add eljefedelrodeodeljefe to collaborators
83721c6 
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@eljefedelrodeodeljefe
doc: fix name to match git log
30ab6a8 
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@eljefedelrodeodeljefe
doc: add eljefedelrodeodeljefe to collaborators
41eff75 
PR-URL: #6389
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@eljefedelrodeodeljefe
doc: fix name to match git log
9752be6 
Git logs print my full name Robert Jefe Lindstaedt.
When I did #6389 I forgot simply forgot it.

PR-URL: #6880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eljefedelrodeodeljefe @ChALkeR @evanlucas @santigimeno @Trott @jbergstroem