tools: fix exit code when linting from CI #6412
Conversation
|
/cc @jbergstroem |
|
This probably should only land after #6411 lands or the CI lint VM is updated to Node.js 6.0.0. |
Before this, if there were lint errors reported by `make jslint-ci`, the process would still exit with an exit code of zero. This commit fixes that to align with `make jslint` (exit with non-zero on lint errors).
mscdex
force-pushed
the
tools-fix-jslint-ci-exit-code
branch
from
7052427 to
c4d4423
Compare
|
I've pushed some additional changes to exit early when a worker dies unexpectedly (e.g. in case of a |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/2413/ |
|
thanks for the heads up. may want to indicate that in the PR description :-) |
|
@jasnell Additional complication is that requirement is only true on master. v4.x can get this PR right now and it will be just fine. |
|
#6411 landed so this can be run in CI now. |
Before this, if there were lint errors reported by `make jslint-ci`, the process would still exit with an exit code of zero. This commit fixes that to align with `make jslint` (exit with non-zero on lint errors). PR-URL: nodejs#6412 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Phillip Johnsen <johphi@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 1264cec |
Before this, if there were lint errors reported by `make jslint-ci`, the process would still exit with an exit code of zero. This commit fixes that to align with `make jslint` (exit with non-zero on lint errors). PR-URL: #6412 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Phillip Johnsen <johphi@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Before this, if there were lint errors reported by `make jslint-ci`, the process would still exit with an exit code of zero. This commit fixes that to align with `make jslint` (exit with non-zero on lint errors). PR-URL: nodejs#6412 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Phillip Johnsen <johphi@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
@mscdex safe to assume this would be included with other linter changes if we were to backport? |
|
@thealphanerd if by 'linter changes' you mean the addition of |
|
that is what I mean |
Checklist
Affected core subsystem(s)
Description of change
Before this, if there were lint errors reported by
make jslint-ci, the process would still exit with an exit code of zero.This commit fixes that to align with
make jslint(exit with code 1 on lint errors).