-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: ensures consistent grammar in node.1 file #6426
Conversation
@nodejs/documentation |
LGTM |
CI, just to be thorough: https://ci.nodejs.org/job/node-test-pull-request/2410/ |
LGTM |
Only CI failure is a currently-problematic test on OS X, so CI is good. |
Should the commit message say |
LGTM. Commit would be better as |
Ah sorry, the convention in my org is to use third person present verbs 😄 |
@justshiv Btw, git thinks your name is If you're ok with that, I'll land this as-is. But if you'd like you can set your name to git by doing:
and then |
PR-URL: nodejs#6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Thanks, landed in 8ebec08 We can always |
PR-URL: #6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: nodejs#6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
oh hey @justshiv !!! so happy to see you got something into core |
PR-URL: #6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #6426 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Checklist
Affected core subsystem(s)
doc
Description of change
Grammar in node.1 file was inconsistent when starting man-page responses (Open vs Opens). I've changed this to ensure these responses are consistent throughout.