Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: ensures consistent grammar in node.1 file #6426

Closed
wants to merge 1 commit into from

Conversation

justshiv
Copy link
Contributor

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Grammar in node.1 file was inconsistent when starting man-page responses (Open vs Opens). I've changed this to ensure these responses are consistent throughout.

@Trott Trott added the doc Issues and PRs related to the documentations. label Apr 27, 2016
@Trott
Copy link
Member

Trott commented Apr 27, 2016

@nodejs/documentation

@Trott
Copy link
Member

Trott commented Apr 27, 2016

LGTM

@Trott
Copy link
Member

Trott commented Apr 27, 2016

CI, just to be thorough: https://ci.nodejs.org/job/node-test-pull-request/2410/

@thefourtheye
Copy link
Contributor

LGTM

@Trott
Copy link
Member

Trott commented Apr 27, 2016

Only CI failure is a currently-problematic test on OS X, so CI is good.

@Trott
Copy link
Member

Trott commented Apr 27, 2016

Should the commit message say ensure instead of ensures? Seems like an unnecessary nit to me, but maybe someone else thinks differently?

@Fishrock123
Copy link
Contributor

LGTM. Commit would be better as ensure, but we can fix that when landing.

@justshiv
Copy link
Contributor Author

Ah sorry, the convention in my org is to use third person present verbs 😄

@Fishrock123
Copy link
Contributor

Fishrock123 commented Apr 29, 2016

@justshiv Btw, git thinks your name is justshiv

If you're ok with that, I'll land this as-is.

But if you'd like you can set your name to git by doing:

$ git config --global user.name "whatever you want to be known as"

and then git commit --amend --reset-author

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 2, 2016
PR-URL: nodejs#6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Thanks, landed in 8ebec08

We can always .mailmap your name later. :)

@Fishrock123 Fishrock123 closed this May 2, 2016
Fishrock123 pushed a commit that referenced this pull request May 4, 2016
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request May 4, 2016
PR-URL: nodejs#6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins
Copy link
Contributor

oh hey @justshiv !!! so happy to see you got something into core

@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6426
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants