doc: remove obsolete comment in isError() example #6486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the util.isError() examples states that a harmony flag is required. As of v6.0.0, this is no longer true. This commit removes the out of date reference. Refs: nodejs#5414
cjihrig
added
util
|
LGTM |
|
LGTM, not sure why the ping @jasnell this looks like an obvious fix in v6 |
|
In general getting in the habit of pinging @nodejs/documentation for anything specifically doc related. |
|
Landed in d09c972 |
This was referenced May 4, 2016
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
May 4, 2016
One of the util.isError() examples states that a harmony flag is required. As of v6.0.0, this is no longer true. This commit removes the out of date reference. Refs: nodejs#5414 PR-URL: nodejs#6486 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
One of the
util.isError()examples states that a harmony flag is required. As of v6.0.0, this is no longer true. This commit removes the out of date reference.Refs: #5414
This should not be backported.