doc: add missing underscore for markdown italics #6529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A closing underscore was missing from the `poll` section of the event loop doc. Also emboldened a word for continuity and readability.
|
LGTM |
|
Thanks, landed in 05f4313 |
Fishrock123
pushed a commit
that referenced
this pull request
May 3, 2016
A closing underscore was missing from the `poll` section of the event loop doc. Also emboldened a word for continuity and readability. PR-URL: #6529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
@Fishrock123 ... for record keeping since you signed off in the commit can you please add a LGTM here as well. |
Fishrock123
pushed a commit
that referenced
this pull request
May 3, 2016
A closing underscore was missing from the `poll` section of the event loop doc. Also emboldened a word for continuity and readability. PR-URL: #6529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Curious but, how is that necessary? Myself and others have done this plenty in the past. LGTM I guess Edit: I guess I should just start signing my commits? idk |
Fishrock123
pushed a commit
that referenced
this pull request
May 4, 2016
A closing underscore was missing from the `poll` section of the event loop doc. Also emboldened a word for continuity and readability. PR-URL: #6529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This was referenced May 4, 2016
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this pull request
May 4, 2016
A closing underscore was missing from the `poll` section of the event loop doc. Also emboldened a word for continuity and readability. PR-URL: nodejs#6529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 2, 2016
A closing underscore was missing from the `poll` section of the event loop doc. Also emboldened a word for continuity and readability. PR-URL: #6529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
A closing underscore was missing from the `poll` section of the event loop doc. Also emboldened a word for continuity and readability. PR-URL: #6529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
A closing underscore was missing from the `poll` section of the event loop doc. Also emboldened a word for continuity and readability. PR-URL: #6529 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
A closing underscore (needed for markdown italicization) was missing from the
pollsection of the eventloop doc. Also emboldened a word for continuity and readability.