Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: optimize checkIsHttpToken() and checkInvalidHeaderChar() #6570

Merged
merged 5 commits into from
Jun 14, 2016
Merged

http: optimize checkIsHttpToken() and checkInvalidHeaderChar() #6570

merged 5 commits into from
Jun 14, 2016

Commits on Jun 14, 2016

  1. http: optimize checkIsHttpToken() 

    This commit both makes checkIsHttpToken() inlinable and extracts
the character checking logic to a separate inlinable function so that
the main loop can be unrolled a bit.

PR-URL: nodejs#6570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    @mscdex
    mscdex committed Jun 14, 2016
    Configuration menu
    Copy the full SHA
    918159e View commit details
    Browse the repository at this point in the history

  2. http: optimize checkInvalidHeaderChar() 

    This commit optimizes checkInvalidHeaderChar() by unrolling the
character checking loop a bit.

Additionally, some changes to the benchmark runner are needed in
order for the included benchmark to be run correctly. Specifically,
the regexp used to parse `key=value` parameters contained a greedy
quantifier that was causing the `key` to match part of the `value`
if `value` contained an equals sign.

PR-URL: nodejs#6570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    @mscdex
    mscdex committed Jun 14, 2016
    Configuration menu
    Copy the full SHA
    83432bf View commit details
    Browse the repository at this point in the history

  3. benchmark: increase http token check iterations 

    PR-URL: nodejs#6570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @mscdex
    mscdex committed Jun 14, 2016
    Configuration menu
    Copy the full SHA
    39fdf07 View commit details
    Browse the repository at this point in the history

  4. test: add more http token/value checking tests 

    PR-URL: nodejs#6570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
    @mscdex
    mscdex committed Jun 14, 2016
    Configuration menu
    Copy the full SHA
    c8fa79f View commit details
    Browse the repository at this point in the history

  5. benchmark: don't convert arguments to numbers 

    PR-URL: nodejs#6570
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @mscdex
    mscdex committed Jun 14, 2016
    Configuration menu
    Copy the full SHA
    c570182 View commit details
    Browse the repository at this point in the history