-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add added:
information for os
#6609
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: nodejs#6578
36 tasks
LGTM |
2 similar comments
LGTM |
LGTM |
LGTM too! 👍 |
LGTM, I’m landing these now :) |
addaleax
pushed a commit
that referenced
this pull request
May 9, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
And landed this in 5a8c66a. Thank you! |
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: nodejs#6578 PR-URL: nodejs#6609 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Via git spelunking, mostly. Some functions have been renamed. Used the version in which they were renamed. Ref: #6578 PR-URL: #6609 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Add
added:
information for os.Via git spelunking, mostly.
Some functions have been renamed. Used the version in which they were
renamed.
Ref: #6578