Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update the printed error stack in the default callback example #6617

Closed
wants to merge 1 commit into from
Closed

doc: update the printed error stack in the default callback example #6617

wants to merge 1 commit into from

Conversation

DavidCai1111
Copy link
Member

@DavidCai1111 DavidCai1111 commented May 6, 2016 •
edited
Loading

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Description of change

Update the error stack printed in the default callback example, matching the latest lib/fs.js.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 6, 2016
@DavidCai1111 DavidCai1111 changed the title doc:update the error stack printed by the default callback example doc:update the printed error stack in the default callback example May 6, 2016
@DavidCai1111 DavidCai1111 changed the title doc:update the printed error stack in the default callback example doc: update the printed error stack in the default callback example May 6, 2016
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label May 6, 2016
@cjihrig
Copy link
Contributor

cjihrig commented May 6, 2016

LGTM, but maybe we should truncate the stack trace earlier than we currently are (move the <etc.> up and drop some additional frames). Keeping the stack trace up to date seems like it could become a bother.

@DavidCai1111
Copy link
Member Author

@cjihrig done : = )

@cjihrig
Copy link
Contributor

cjihrig commented May 6, 2016

Nice. LGTM.

@jasnell
Copy link
Member

jasnell commented May 6, 2016

+1 that's better. LGTM

claudiorodriguez pushed a commit that referenced this pull request May 15, 2016
@DavidCai1111 @claudiorodriguez
doc: update fs callback example error stack
32b46d9 
Update the error stack printed in the default callback
example in the fs doc, matching the latest lib/fs.js.
Truncates the stack to make it easier to update in the future.

PR-URL: #6617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@claudiorodriguez
Copy link
Contributor

Landed in 32b46d9

evanlucas pushed a commit that referenced this pull request May 17, 2016
@DavidCai1111 @evanlucas
doc: update fs callback example error stack
49af20c 
Update the error stack printed in the default callback
example in the fs doc, matching the latest lib/fs.js.
Truncates the stack to make it easier to update in the future.

PR-URL: #6617
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@DavidCai1111 @cjihrig @jasnell @claudiorodriguez @mscdex @MylesBorins @nodejs-github-bot