Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pass python path to node-gyp #6646

Closed
wants to merge 1 commit into from

Conversation

hefangshi
Copy link
Contributor

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

@bnoordhuis bnoordhuis added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels May 9, 2016
@bnoordhuis
Copy link
Member

@addaleax
Copy link
Member

LGTM

@addaleax
Copy link
Member

@hefangshi You author name in this commit is given as “Sighless”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

@hefangshi
Copy link
Contributor Author

@addaleax Thanks for mention this, I prefer to use full name rather than "Sighless", is threre some way to change that?

@bnoordhuis
Copy link
Member

@hefangshi git commit --amend --author="Your Name <youremail@example.com>", then force-push to your feature branch. To make git remember your name and email:

$ git config --global user.name "Your Name"
$ git config --global user.email youremail@example.com

node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.
@hefangshi
Copy link
Contributor Author

@bnoordhuis @addaleax Thanks, already changed ;)

@addaleax
Copy link
Member

@hefangshi “hefangshi” is correct, right? Just checking to make sure it’s really what you want, because you just changed the name on your profile to “Fangshi He” and that would be okay just as well.

@hefangshi
Copy link
Contributor Author

@addaleax hefangshi is fine ;)

addaleax pushed a commit that referenced this pull request May 12, 2016
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax
Copy link
Member

Thanks! Landed in 25f8d04.

@addaleax addaleax closed this May 12, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins
Copy link
Contributor

@addaleax lts?

@addaleax
Copy link
Member

addaleax commented Jun 2, 2016

@thealphanerd yep 👍

MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
node-gyp rebuild should use the same python interpreter as in Makefile
rather than let node-gyp guess the python path by itself.

PR-URL: #6646
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants