test: ensure test-npm-install uses correct node #6658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci: https://ci.nodejs.org/job/node-test-pull-request/2550/ |
mscdex
added
the
npm
|
fixes: #6648 |
MylesBorins
force-pushed
the
npm-test-explicit-path
branch
from
501ba75
to
65453b8
Compare
| @@ -29,11 +29,13 @@ const pkgContent = JSON.stringify({ | |||
| }); | |||
|
|
|||
| const pkgPath = path.join(common.tmpDir, 'package.json'); | |||
|
|
|||
|
Related to #6220 in any way? |
MylesBorins
force-pushed
the
npm-test-explicit-path
branch
from
65453b8
to
19c4240
Compare
|
Okay, LGTM then. |
|
another ci run |
| cwd: common.tmpDir | ||
| cwd: common.tmpDir, | ||
| env: { | ||
| path: path.dirname(process.execPath) |
There was a problem hiding this comment.
indeed... good eye
MylesBorins
force-pushed
the
npm-test-explicit-path
branch
from
19c4240
to
e8543bb
Compare
|
nits addressed @bnoordhuis @Fishrock123 |
|
lgtm if it works |
|
ci mater: https://ci.nodejs.org/job/node-test-pull-request/2562/ I'm running CI against both master + v4.x as this fix should only really matter with npm v2 |
|
LGTM |
Currently it is possible that the shelled out instance of npm will use the system copy of node. This PR changes the test to shim the build directory into the path. This will ensure that npm will use the correct version of node. fixes: nodejs#6648 PR-URL: nodejs#6658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
force-pushed
the
npm-test-explicit-path
branch
from
e8543bb
to
738a1d6
Compare
MylesBorins
pushed a commit
that referenced
this pull request
May 11, 2016
Currently it is possible that the shelled out instance of npm will use the system copy of node. This PR changes the test to shim the build directory into the path. This will ensure that npm will use the correct version of node. fixes: #6648 PR-URL: #6658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Currently it is possible that the shelled out instance of npm will use the system copy of node. This PR changes the test to shim the build directory into the path. This will ensure that npm will use the correct version of node. fixes: #6648 PR-URL: #6658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
Currently it is possible that the shelled out instance of npm will use the system copy of node. This PR changes the test to shim the build directory into the path. This will ensure that npm will use the correct version of node. fixes: #6648 PR-URL: #6658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
documentation is changed or addedAffected core subsystem(s)
test
Description of change
Currently it is possible that the shelled out instance of npm will use
the system copy of node. This PR changes the test to shim the build
directory into the path. This will ensure that npm will use the correct
version of node.