test: fix test-debugger-repl-term #6682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-debugger-repl-term had incorrect expected output and so was failing. It was likely dependent on previous bugs in the debugger. The fixture file has been modified so that the output is as expected.
|
@nodejs/testing |
|
It passes in my box with this change. LGTM. |
|
LGTM, passes for me locally as well with your change. I second moving to sequential or parallel. It doesn't appear to be flaky (common issue with the debugger tests); I ran it a few hundred times in a loop and it never failed. |
|
Single failure in CI seems unrelated, but just in case: |
|
And this time, the only failure was a buildbot explosion. Landing... |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 13, 2016
test-debugger-repl-term had incorrect expected output and so was failing. It was likely dependent on previous bugs in the debugger. The fixture file has been modified so that the output is as expected. PR-URL: nodejs#6682 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
|
Landed in 991ce2d |
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
test-debugger-repl-term had incorrect expected output and so was failing. It was likely dependent on previous bugs in the debugger. The fixture file has been modified so that the output is as expected. PR-URL: #6682 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 2, 2016
test-debugger-repl-term had incorrect expected output and so was failing. It was likely dependent on previous bugs in the debugger. The fixture file has been modified so that the output is as expected. PR-URL: #6682 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 2, 2016
test-debugger-repl-term had incorrect expected output and so was failing. It was likely dependent on previous bugs in the debugger. The fixture file has been modified so that the output is as expected. PR-URL: #6682 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
test-debugger-repl-term had incorrect expected output and so was failing. It was likely dependent on previous bugs in the debugger. The fixture file has been modified so that the output is as expected. PR-URL: #6682 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
test-debugger-repl-term had incorrect expected output and so was failing. It was likely dependent on previous bugs in the debugger. The fixture file has been modified so that the output is as expected. PR-URL: #6682 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test debugger
Description of change
test-debugger-repl-term had incorrect expected output and so was
failing. It was likely dependent on previous bugs in the debugger.
The fixture file has been modified so that the output is as expected.