Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add added: information for v8 #6684

Closed
wants to merge 1 commit into from
Closed

doc: add added: information for v8 #6684

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented May 11, 2016

Checklist
  • tests and code linting passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc v8

Description of change

@Trott Trott added doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency. labels May 11, 2016
@sam-github sam-github mentioned this pull request May 11, 2016
Closed
36 tasks
@bnoordhuis
Copy link
Member

LGTM

2 similar comments
@claudiorodriguez
Copy link
Contributor

LGTM

@Qard
Copy link
Member

Qard commented May 11, 2016

LGTM

@addaleax
Copy link
Member

LGTM but it may be nice to have the Ref: field as in the other commit messages, if only for consistency :)

@Trott
Copy link
Member Author

Trott commented May 12, 2016

Ref: added, rebased, force pushed.

@Trott
Copy link
Member Author

Trott commented May 12, 2016

And just to have the Ref here:

Ref: #6578

@Trott
Copy link
Member Author

Trott commented May 13, 2016

Doc-only change, but exercising caution anyway: https://ci.nodejs.org/job/node-test-pull-request/2618/

@Trott
Copy link
Member Author

Trott commented May 13, 2016

Only CI failure was a buildbot failure. Landing...

Trott added a commit to Trott/io.js that referenced this pull request May 13, 2016
@Trott
doc: add added: information for v8
b3bc362 
PR-URL: nodejs#6684
Ref: nodejs#6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented May 13, 2016

Landed in b3bc362

@Trott Trott closed this May 13, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
@Trott @evanlucas
doc: add added: information for v8
f1c773d 
PR-URL: #6684
Ref: #6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
@Trott @addaleax
doc: add added: information for v8
e5392f0 
PR-URL: nodejs#6684
Ref: nodejs#6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
doc: add added: information for v8
effe930 
PR-URL: #6684
Ref: #6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
doc: add added: information for v8
9f32a1c 
PR-URL: #6684
Ref: #6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
doc: add added: information for v8
02af985 
PR-URL: #6684
Ref: #6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
doc: add added: information for v8
3e3471f 
PR-URL: #6684
Ref: #6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott Trott deleted the v8 branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @bnoordhuis @claudiorodriguez @Qard @addaleax @MylesBorins