Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appendFileSync accepts fd. Was not specified in its doc #6707

Closed
wants to merge 1 commit into from
Closed

appendFileSync accepts fd. Was not specified in its doc #6707

wants to merge 1 commit into from

Conversation

fhalde
Copy link
Contributor

@fhalde fhalde commented May 12, 2016 •
edited by thefourtheye
Loading

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

In reference to the issues #6508. appendFileSync doc does not state anything about it accepting file descriptors too. Fixed that

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 12, 2016
@addaleax addaleax added the fs Issues and PRs related to the fs subsystem / file system. label May 12, 2016
@addaleax
Copy link
Member

LGTM

@targos
Copy link
Member

targos commented May 12, 2016

LGTM

@thefourtheye
Copy link
Contributor

LGTM

2 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented May 13, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented May 13, 2016

LGTM

jasnell pushed a commit that referenced this pull request May 13, 2016
@fhalde @jasnell
doc: appendFileSync accepts fd as well
fc96fda 
Refs: #6508
PR-URL: #6707
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented May 13, 2016

Landed in fc96fda

@jasnell jasnell closed this May 13, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
@fhalde @evanlucas
doc: appendFileSync accepts fd as well
64fcba2 
Refs: #6508
PR-URL: #6707
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fhalde @addaleax @targos @thefourtheye @cjihrig @jasnell @nodejs-github-bot