-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: move uncoupled debugger tests to sequential #6731
Conversation
LGTM if CI is green: https://ci.nodejs.org/job/node-test-pull-request/2628/ |
LGTM in theory. The CI seemed to have a bad time though. |
Ugh. I think I see what the problem is, but uh, small steps first. It looks like one of the tests moved is working A-OK in CI so let's move that one first... moved the others back and force pushed... |
Move test from `test/debugger` to `test/sequential` so that it is exercised by CI and `make test`.
(Amended commit message and force pushed.) |
CI is green. |
LGTM but I'm wondering if we should hold off a bit to see what's causing the others to fail. |
@jasnell I think the others are failing because of a race condition but I'd like to address it separately. Since these tests have not been seeing any activity with any regularity, I guess it's not surprising that they may not be 100% bullet-proof. I'd prefer to move the one working test over by itself so that if something comes up and we do have to revert something somewhere, it's an easy and atomic revert that doesn't affect multiple things at once. The other tests will need to be modified and I'd rather blend the move-as-is commit with those modifications. |
Ok. No problems then
|
Move test from `test/debugger` to `test/sequential` so that it is exercised by CI and `make test`. PR-URL: nodejs#6731 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 5a5b74a |
Move test from `test/debugger` to `test/sequential` so that it is exercised by CI and `make test`. PR-URL: #6731 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
Affected core subsystem(s)
test debugger
Description of change
Move tests from
test/debugger
totest/sequential
so that they areexercised by CI and
make test
. This change only moves tests that haveno dependencies that break when moved to a different directory.
The remaining tests can move in a subsequent PR that will have other (minor) changes required so the tests can run in
sequential
./cc @bnoordhuis @santigimeno