Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dgram,test: add tests for setBroadcast() #6750

Closed
wants to merge 2 commits into from
Closed

dgram,test: add tests for setBroadcast() #6750

wants to merge 2 commits into from

Commits on May 16, 2016

  1. doc: add added info for dgram.setBroadcast() 

    Since I was doing the necessary git spelunking anyway, I took the time
to add the YAML information into the docs about when `setBroadcast()`
first appeared in its current form.
    @Trott
    Trott committed May 16, 2016
    Configuration menu
    Copy the full SHA
    799da24 View commit details
    Browse the repository at this point in the history

  2. test,dgram: add tests for setBroadcast() 

    The only tests for `setBroadcast()` (from the `dgram` module) were in
`test/internet` which means they almost never get run. This adds a
minimal test that can check JS-land functionality in `test/parallel`.

I also expanded a comment and did some minor formatting on the existing
`test/internet` test. If there were an easy and reliable way to check
for the BROADCAST flag on an interface, it's possible that a version of
the test could be moved to `test/sequential` or `test/parallel` once it
was modified to only use internal networks.
    @Trott
    Trott committed May 16, 2016
    Configuration menu
    Copy the full SHA
    0f5960b View commit details
    Browse the repository at this point in the history