test: refactor test-tls-reuse-host-from-socket #6756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
tls
|
LGTM if CI is green. |
| secureSocket.destroy(); | ||
| }); | ||
| }); | ||
| console.log('ok'); |
There was a problem hiding this comment.
I left it in to preserve the original test's logging. But I'm happy to take it out.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/2646/. LGTM if CI is green. |
| connected = true; | ||
| var secureSocket = tls.connect({ socket: socket }, function() { | ||
| secure = true; | ||
| const socket = net.connect(443, 'www.google.com', common.mustCall(() => { |
There was a problem hiding this comment.
Can this be pointed at a non-specific url? www.example.org for instance?
|
Minor nit, otherwise LGTM |
Trott
force-pushed
the
tlsyo
branch
2 times, most recently
from
0acd996 to
34cfca9
Compare
Replace booleans with `common.mustCall()`, migrate from `var` to `const`, and apply minor formatting changes.
|
Fixed a nit, rebased, force pushed. CI: https://ci.nodejs.org/job/node-test-pull-request/2706/ |
|
Ci is green. Landing... |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 19, 2016
Replace booleans with `common.mustCall()`, migrate from `var` to `const`, and apply minor formatting changes. PR-URL: nodejs#6756 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 395cc88 |
Fishrock123
pushed a commit
that referenced
this pull request
May 23, 2016
Replace booleans with `common.mustCall()`, migrate from `var` to `const`, and apply minor formatting changes. PR-URL: #6756 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
Replace booleans with `common.mustCall()`, migrate from `var` to `const`, and apply minor formatting changes. PR-URL: #6756 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 3, 2016
Replace booleans with `common.mustCall()`, migrate from `var` to `const`, and apply minor formatting changes. PR-URL: #6756 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Replace booleans with `common.mustCall()`, migrate from `var` to `const`, and apply minor formatting changes. PR-URL: #6756 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Replace booleans with `common.mustCall()`, migrate from `var` to `const`, and apply minor formatting changes. PR-URL: #6756 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test tls
Description of change
Replace booleans with
common.mustCall(), migrate fromvartoconst, and apply minor formatting changes./cc @nodejs/testing @nodejs/crypto