Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update vm.runInDebugContext() example #6757

Merged
merged 1 commit into from
May 16, 2016
Merged

doc: update vm.runInDebugContext() example #6757

merged 1 commit into from
May 16, 2016

Conversation

bnoordhuis
Copy link
Member

The debugger needs to be active now before one is allowed to query the
list of scripts. Replace the example with one that works without
installing a debug event listener first.

Fixes: #4862

R=@thealphanerd

@bnoordhuis bnoordhuis added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. lts-watch-v4.x labels May 14, 2016
@cjihrig
Copy link
Contributor

cjihrig commented May 15, 2016

LGTM, but this seems to be the only example in the vm docs that doesn't require('vm').

@MylesBorins
Copy link
Contributor

LGTM

@bnoordhuis
doc: update vm.runInDebugContext() example
f17b949 
The debugger needs to be active now before one is allowed to query the
list of scripts.  Replace the example with one that works without
installing a debug event listener first.

Fixes: nodejs#4862
PR-URL: nodejs#6757
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@bnoordhuis bnoordhuis closed this May 16, 2016
@bnoordhuis bnoordhuis deleted the fix4862 branch May 16, 2016 06:11
@bnoordhuis bnoordhuis merged commit f17b949 into nodejs:master May 16, 2016
@bnoordhuis
Copy link
Member Author

Landed with added const vm = require('vm'); in f17b949. Thanks for the review.

evanlucas pushed a commit that referenced this pull request May 17, 2016
@bnoordhuis @evanlucas
doc: update vm.runInDebugContext() example
688f563 
The debugger needs to be active now before one is allowed to query the
list of scripts.  Replace the example with one that works without
installing a debug event listener first.

Fixes: #4862
PR-URL: #6757
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@bnoordhuis
doc: update vm.runInDebugContext() example
a2339e4 
The debugger needs to be active now before one is allowed to query the
list of scripts.  Replace the example with one that works without
installing a debug event listener first.

Fixes: #4862
PR-URL: #6757
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@bnoordhuis
doc: update vm.runInDebugContext() example
50f02bd 
The debugger needs to be active now before one is allowed to query the
list of scripts.  Replace the example with one that works without
installing a debug event listener first.

Fixes: #4862
PR-URL: #6757
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnoordhuis @cjihrig @MylesBorins