Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade npm to 3.9.0 #6788

Closed
wants to merge 1 commit into from
Closed

upgrade npm to 3.9.0 #6788

wants to merge 1 commit into from

Conversation

iarna
Copy link
Member

@iarna iarna commented May 16, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of change

The biggest thing in this release is that it fixes the tests on Windows.

There are a couple of Windows related bug fixes that were exposed by fixing the tests on Windows. Notably:

  • The use of npm explore to run a command from the directory of a dependency didn't work correctly on Windows.
  • npm init and others that inferred the module name from the path failed with scoped modules on Windows.
  • Removing globally installed bins for scoped modules previously failed on Windows. (And was incorrect, but working by-accident elsewhere.)
  • Correct npm cache ls to output real filenames– previously it sometimes mistakenly double the package name in the path, resulting paths that don't exist.
  • npm now warns if you paste in a command line that uses non-ascii dashes (like emdashes or endashes), as this is almost certainly not intended.

And one new feature:

  • If we got a cache-hit for module metadata but the version requested does not exist in the metadata, we then explicitly ask the registry for updated metadata. This removes one of the primary pain points of using a very high --cache-min.
Changelogs
Reviewers

r: @zkat
r: @thealphanerd
r: @Fishrock123

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label May 16, 2016
@MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins self-assigned this May 16, 2016
# EOL summer 2016, most likely
- nodejs_version: "0.8"
COVERALLS_REPO_TOKEN:
secure: XdC0aySefK0HLh1GNk6aKrzZPbCfPQLyA4mYtFGEp4DrTuZA/iuCUS0LDqFYO8JQ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iarna ... I'm not too familiar with coveralls but I want to verify... was including the COVERALLS_REPO_TOKEN here and the slack incoming_webhook secure token intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell We've included the slack one in Travis throughout. They're all public in the npm repo, so there's little harm in them being here.

@Fishrock123
Copy link
Contributor

Fwiw:

Applying: deps: upgrade npm to 3.9.0
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:1098: trailing whitespace.
The `--ignore-scripts` argument will cause npm to not execute any 
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:1111: trailing whitespace.
3. Developer, works on packages they are given access to.  
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:1120: trailing whitespace.
* Grant access:  
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:1133: trailing whitespace.
default will only publish internally. 
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:1366: trailing whitespace.
<p>The <code>--ignore-scripts</code> argument will cause npm to not execute any 
warning: squelched 1133 whitespace errors
warning: 1035 lines applied after fixing whitespace errors.

That's an awful lot lol

@MylesBorins
Copy link
Contributor

local tests pass make test-npm with this patch applied to master

@Fishrock123
Copy link
Contributor

Tests also pass for me. @iarna Do the whitespace squelches concern you at all? If not, I'll go ahead and land this.

@iarna
Copy link
Member Author

iarna commented May 16, 2016

Let me fix the whitespace nonsense. I thought I'd done that, but I think I crossed wires with the 2.x branch.

@iarna
Copy link
Member Author

iarna commented May 16, 2016

Whitespace fixed.

@chicoxyzzy
Copy link

notice npm/npm#12647

@Fishrock123
Copy link
Contributor

@iarna Is there anything critical in this release? The above issue sounds like we should hold out for 3.9.1 or similar?

@MylesBorins
Copy link
Contributor

closing in favor of #7139

@MylesBorins MylesBorins closed this Jun 6, 2016
@MylesBorins MylesBorins removed their assignment Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants