-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade npm to 3.9.0 #6788
upgrade npm to 3.9.0 #6788
Conversation
# EOL summer 2016, most likely | ||
- nodejs_version: "0.8" | ||
COVERALLS_REPO_TOKEN: | ||
secure: XdC0aySefK0HLh1GNk6aKrzZPbCfPQLyA4mYtFGEp4DrTuZA/iuCUS0LDqFYO8JQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iarna ... I'm not too familiar with coveralls but I want to verify... was including the COVERALLS_REPO_TOKEN
here and the slack incoming_webhook secure token intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell We've included the slack one in Travis throughout. They're all public in the npm repo, so there's little harm in them being here.
Fwiw:
That's an awful lot lol |
local tests pass |
Tests also pass for me. @iarna Do the whitespace squelches concern you at all? If not, I'll go ahead and land this. |
Let me fix the whitespace nonsense. I thought I'd done that, but I think I crossed wires with the 2.x branch. |
Whitespace fixed. |
notice npm/npm#12647 |
@iarna Is there anything critical in this release? The above issue sounds like we should hold out for 3.9.1 or similar? |
closing in favor of #7139 |
Checklist
Affected core subsystem(s)
deps
Description of change
The biggest thing in this release is that it fixes the tests on Windows.
There are a couple of Windows related bug fixes that were exposed by fixing the tests on Windows. Notably:
npm explore
to run a command from the directory of a dependency didn't work correctly on Windows.npm init
and others that inferred the module name from the path failed with scoped modules on Windows.npm cache ls
to output real filenames– previously it sometimes mistakenly double the package name in the path, resulting paths that don't exist.npm
now warns if you paste in a command line that uses non-ascii dashes (like emdashes or endashes), as this is almost certainly not intended.And one new feature:
--cache-min
.Changelogs
Reviewers
r: @zkat
r: @thealphanerd
r: @Fishrock123