Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify fs.mkdtemp prefix argument #6800

Closed
wants to merge 2 commits into from
Closed

doc: clarify fs.mkdtemp prefix argument #6800

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented May 17, 2016 •
edited
Loading

Checklist
  • documentation is changed or added
Affected core subsystem(s)

doc (fs)

Description of change

Per: #6142

Clarify the prefix argument.

@nodejs/fs @nodejs/documentation

@jasnell
doc: clarify fs.mkdtemp prefix argument
2aad164 
Per: nodejs#6142

Clarify the prefix argument.

Fixes: nodejs#6142
@jasnell jasnell added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels May 17, 2016
@bnoordhuis
Copy link
Member

LGTM

thefourtheye
thefourtheye reviewed May 17, 2016
View reviewed changes
doc/api/fs.md

```js
// The parent directory for the new temporary directory
const tmp_dir = '/tmp';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we follow camel casing for js variables, right?

@jasnell
Copy link
Member Author

jasnell commented May 17, 2016

@thefourtheye ... nits fixed.

@r-52
Copy link
Contributor

r-52 commented May 17, 2016

LGTM

jasnell added a commit that referenced this pull request May 18, 2016
@jasnell
doc: clarify fs.mkdtemp prefix argument
2ccba1f 
Per: #6142

Clarify the prefix argument.

Fixes: #6142
PR-URL: #6800
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented May 18, 2016

Landed in 2ccba1f

@jasnell jasnell closed this May 18, 2016
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
@jasnell @Fishrock123
doc: clarify fs.mkdtemp prefix argument
3d7ce17 
Per: #6142

Clarify the prefix argument.

Fixes: #6142
PR-URL: #6800
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@jasnell @rvagg
doc: clarify fs.mkdtemp prefix argument
5cad04b 
Per: #6142

Clarify the prefix argument.

Fixes: #6142
PR-URL: #6800
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 2, 2016
Closed
@vtjnash vtjnash mentioned this pull request Mar 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @bnoordhuis @r-52 @thefourtheye @MylesBorins