Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add added: information for punycode #6805

Closed

Conversation

firedfox
Copy link
Contributor

Checklist
  • tests and code linting passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Ref: #6578

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 17, 2016
@addaleax
Copy link
Member

LGTM, thank you for the work here!

@jasnell
Copy link
Member

jasnell commented May 17, 2016

LGTM but I'd like @bnoordhuis to verify/doublecheck the versions on this one if possible

@@ -27,6 +33,9 @@ punycode.encode('☃-⌘'); // '--dqo34k'
```

## punycode.toASCII(domain)
<!-- YAML
added: v0.6.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.6.1 actually. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnoordhuis You are right. I'll fix it right away. I was misled by the punycode doc.

[Punycode.js][] is bundled with Node.js v0.6.2+.

I'll fix it, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnoordhuis All fixed. Thank you very much!

@firedfox firedfox force-pushed the add-added-infomation-for-punycode branch from ac1906e to 11c71fe Compare May 18, 2016 18:10
@firedfox
Copy link
Contributor Author

Sorry for making so many mistakes. Obviously I should rely on binaries but not docs. I'm working on a script to check the versions by calling methods within all nodejs binaries, from v0.1.14 to v6.2.0.

@@ -2,11 +2,14 @@

Stability: 2 - Stable

[Punycode.js][] is bundled with Node.js v0.6.2+. Use `require('punycode')` to
[Punycode.js][] is bundled with Node.js v0.6.1+. Use `require('punycode')` to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this should be v0.5.1. The first punycode.js was https://github.com/bnoordhuis/punycode.js and was later replaced with https://github.com/bestiejs/punycode.js.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done! Thanks!

@firedfox firedfox force-pushed the add-added-infomation-for-punycode branch from 11c71fe to edf1b4c Compare May 18, 2016 18:38
@bnoordhuis
Copy link
Member

Thanks Daniel, landed in b90c52e.

@bnoordhuis bnoordhuis closed this May 19, 2016
bnoordhuis pushed a commit that referenced this pull request May 19, 2016
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
PR-URL: nodejs#6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #6805
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants