Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport debugger test commits (6205, 6246) #6831

Closed
wants to merge 2 commits into from

Commits on May 18, 2016

  1. test: move debugger tests to sequential

    The debugger tests in parallel fail with `make test` sometimes (all the
    time?). This appears to be related to running in parallel, as it does
    not fail with `make test-ci`, when run via `tools/test.py` or directly
    from the command line with `./node
    test/parallel/test-debugger-util-regression.js`.
    
    A separate issue may be opened to find out why it is failing in
    parallel, but for now, I think it's important to fix `make test`
    promptly.
    
    I suspect the issue is that the tests are relying on a default port
    somewhere and so they are colliding when run in parallel. But that's
    just a guess for the moment.
    
    PR-URL: nodejs#6205
    Fixes: nodejs#6201
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    Trott authored and santigimeno committed May 18, 2016
    Configuration menu
    Copy the full SHA
    48e50cb View commit details
    Browse the repository at this point in the history
  2. test: move the debugger tests back to parallel

    Run the debugger with `--port=common.PORT` to avoid the use of the same
    port.
    
    PR-URL: nodejs#6246
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    santigimeno committed May 18, 2016
    Configuration menu
    Copy the full SHA
    639dee3 View commit details
    Browse the repository at this point in the history