udp: use libuv API to get file descriptor

[saghul]

Refs: #6838 (comment)

[bnoordhuis]

LGTM

[jasnell]

LGTM... would be ideal if there was some way to actually test this tho so we don't get regressions later

[cjihrig]

LGTM

[saghul]

@jasnell I'm open to suggestions, but how do we test that the way to obtain that value has changed in C++ ? FWIW, before this change Node was relying on libuv internals, which can be seen as "broken" already, because we could've changed it without notice.

[jasnell]

;-) I didn't say I had any good suggestions for a test ;-) I'm fine with this landing as is, but if someone can come up with a way of testing then +1

[MylesBorins]

@saghul is it safe to assume that this will be neccessary if we want to backport libuv 1.9? Not entirely sure if this should land or not either way

[saghul]

I'd land it because it poses 0 risk and it makes process.std*._handle.fd
always return the right thing.
On Jun 3, 2016 02:33, "Myles Borins" notifications@github.com wrote:

@saghul https://github.com/saghul is it safe to assume that this will
be neccessary if we want to backport libuv 1.9? Not entirely sure if this
should land or not either way

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6908 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AATYGI0aeG1HE4S4xGdPzO_HtqIEWxXPks5qH4RmgaJpZM4IjmbB
.