Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improve rendering of v4.4.5 changelog entry #6958

Merged
merged 1 commit into from
Jun 1, 2016

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented May 24, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Remove extra newlines that were causing rendering problems.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 24, 2016
@MylesBorins MylesBorins added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. lts-watch-v4.x and removed doc Issues and PRs related to the documentations. v4.x labels May 24, 2016
@MylesBorins
Copy link
Contributor Author

/cc @Fishrock123

@Fishrock123
Copy link
Contributor

lgtm

@addaleax
Copy link
Member

While you’re changing this anyway, could you also change the “notable changes” text for the buffer thing? In v4, only .indexOf is by us, .lastIndexOf is from Uint8Array, so the only changes that were backported were for .indexOf with UTF-16 encoding… maybe something along the lines of

Buffer.indexOf now returns correct values for all UTF-16 input?

Sorry for not catching that earlier.

@MylesBorins
Copy link
Contributor Author

@addaleax updated... PTAL

@addaleax
Copy link
Member

addaleax commented Jun 1, 2016

@thealphanerd Looks good, thanks!

@MylesBorins MylesBorins force-pushed the fix-changelog branch 2 times, most recently from d47f7f0 to 8c1d5e5 Compare June 1, 2016 20:15
Remove extra newlines that were causing rendering problems.

PR-URL: nodejs#6958
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins merged commit 8c1d5e5 into nodejs:master Jun 1, 2016
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
Remove extra newlines that were causing rendering problems.

PR-URL: #6958
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins deleted the fix-changelog branch June 13, 2016 18:05
MylesBorins pushed a commit that referenced this pull request Jun 23, 2016
Remove extra newlines that were causing rendering problems.

PR-URL: #6958
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
Remove extra newlines that were causing rendering problems.

PR-URL: #6958
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants