doc: add added: information for tls
#7018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
wip
| @@ -134,7 +134,6 @@ threshold is exceeded. The limits are configurable: | |||
| requests. Defaults to `3`. | |||
| * `tls.CLIENT_RENEG_WINDOW` {number} Specifies the time renegotiation window | |||
| in seconds. Defaults to `600` (10 minutes). | |||
|
|
|||
|
LGTM with a nit |
| @@ -1019,6 +1024,9 @@ openssl s_client -connect 127.0.0.1:8000 | |||
| ``` | |||
|
|
|||
| ## tls.getCiphers() | |||
| <!--YAML | |||
| v0.10.2 | |||
There was a problem hiding this comment.
this should have added: before it
There was a problem hiding this comment.
sigh.. completely overlooked that ;-) good catch.
|
(correction, LGTM with nits addressed ;-) ...) |
|
@addaleax this is done. |
| @@ -473,7 +523,9 @@ https://www.openssl.org/docs/manmaster/ssl/SSL_CIPHER_get_name.html for more | |||
| information. | |||
|
|
|||
| ### tlsSocket.getEphemeralKeyInfo() | |||
|
|
|||
| <!--YAML | |||
| added: v5.0.0-rc.1 | |||
There was a problem hiding this comment.
Release candidates don’t really count, you can just set this to v5.0.0
|
|
||
| Returns a `Buffer` instance holding the keys currently used for | ||
| encryption/decryption of the [TLS Session Tickets][] | ||
|
|
||
| ### server.listen(port[, hostname][, callback]) | ||
| <!-- YAML | ||
| added: v0.11.3 | ||
| --> |
|
I'm going to review this entire module again. |
|
LGTM |
|
Landed in c2e6078 with minor whitespace fixups, thanks! |
36 tasks
Merged
Merged
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
Ref: nodejs#6578 PR-URL: nodejs#7018 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Add
added:information fortlsRef: #6578