Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/postmortem #706

Closed
wants to merge 3 commits into from
Closed

Fix/postmortem #706

wants to merge 3 commits into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Feb 3, 2015

cc @bnoordhuis
see #461

@bnoordhuis
Copy link
Member

LGTM, however... I think this PR is a good a place as any to start a discussion about out-of-tree patches. I would like us to adopt a policy where we commit to not landing such patches until after they have been accepted upstream. Even better would be if we persuade the V8 people to back-port the change and simply upgrade.

Good idea/bad idea?

@indutny
Copy link
Member Author

indutny commented Feb 3, 2015

Makes sense. v8/v8@a0d0c43 .

indutny added a commit that referenced this pull request Feb 3, 2015
Fix: #461
PR-URL: #706
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
indutny added a commit that referenced this pull request Feb 3, 2015
Fix: #461
PR-URL: #706
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
indutny added a commit that referenced this pull request Feb 3, 2015
Fix: #461
PR-URL: #706
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@indutny
Copy link
Member Author

indutny commented Feb 3, 2015

Landed in 8b88ff8, 6a5d731, 14684d3. Thank you!

@indutny indutny closed this Feb 3, 2015
@indutny indutny deleted the fix/postmortem branch February 3, 2015 16:30
bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this pull request Feb 25, 2015
Fix: nodejs#461
PR-URL: nodejs#706
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@rvagg rvagg mentioned this pull request Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants