Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use stack-allocated Environment instances #7090

Merged
merged 2 commits into from
Jun 2, 2016
Merged

src: use stack-allocated Environment instances #7090

merged 2 commits into from
Jun 2, 2016

Commits on Jun 2, 2016

  1. src: move env init logic into Environment class 

    PR-URL: nodejs#7090
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    58cec4e View commit details
    Browse the repository at this point in the history

  2. src: use stack-allocated Environment instances 

    Makes it easier to reason about the lifetime of the Environment object.

PR-URL: nodejs#7090
Refs: nodejs#7082
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 2, 2016
    Configuration menu
    Copy the full SHA
    aac79df View commit details
    Browse the repository at this point in the history