Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "test: abstract skip functionality to common" #7114

Closed
wants to merge 1 commit into from
Closed

Backport "test: abstract skip functionality to common" #7114

wants to merge 1 commit into from

Conversation

Fishrock123
Copy link
Contributor

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

Manual re-do of #6697 since backporting doesn't really work.

cc @thealphanerd

@Fishrock123
test: abstract skip functionality to common
f972086 
The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

Re-do of 52bae22 for v4.x
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 2, 2016
@Fishrock123 Fishrock123 mentioned this pull request Jun 2, 2016
Merged
3 tasks
@Fishrock123 Fishrock123 changed the title test: abstract skip functionality to common Backport "test: abstract skip functionality to common" Jun 2, 2016
@MylesBorins
Copy link
Contributor

ci: https://ci.nodejs.org/job/node-test-pull-request/2904/

@MylesBorins
Copy link
Contributor

ci is green LGTM

MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
@Fishrock123
test: abstract skip functionality to common
964ee06 
The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

Re-do of 52bae22 for v4.x

Ref: #6697
PR-URL: #7114
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 964ee06

@MylesBorins MylesBorins closed this Jun 2, 2016
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
@Fishrock123
test: abstract skip functionality to common
b6e3c46 
The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

Re-do of 52bae22 for v4.x

Ref: #6697
PR-URL: #7114
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@Fishrock123
test: abstract skip functionality to common
4067cde 
The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

Re-do of 52bae22 for v4.x

Ref: #6697
PR-URL: #7114
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@Fishrock123
test: abstract skip functionality to common
62bfe18 
The tap skipping output is so prevalent yet obscure in nature that we
ought to move it into it's own function in test/common.js

Re-do of 52bae22 for v4.x

Ref: #6697
PR-URL: #7114
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fishrock123 @MylesBorins @nodejs-github-bot