Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: url.format() parameter may be a string #7235

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 8, 2016

Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc url

Description of change

@Trott Trott added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Jun 8, 2016
@jasnell
Copy link
Member

jasnell commented Jun 8, 2016

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Jun 9, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Jun 11, 2016
PR-URL: nodejs#7235
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 11, 2016

Landed in f2c59d9

@Trott Trott closed this Jun 11, 2016
evanlucas pushed a commit that referenced this pull request Jun 16, 2016
PR-URL: #7235
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
@evanlucas evanlucas mentioned this pull request Jun 16, 2016
@Trott Trott deleted the wha branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants