Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix erroneous fallthrough in ParseEncoding() #7262

Merged
merged 2 commits into from
Jun 13, 2016
Merged

src: fix erroneous fallthrough in ParseEncoding() #7262

merged 2 commits into from
Jun 13, 2016

Commits on Jun 13, 2016

  1. test: rebuild add-ons when their sources change 

    The prerequisite for rebuilding was on the binding.gyp file but the
actual sources.

PR-URL: nodejs#7262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 13, 2016
    Configuration menu
    Copy the full SHA
    9ce8882 View commit details
    Browse the repository at this point in the history

  2. src: fix erroneous fallthrough in ParseEncoding() 

    A missing 'break' statement unintentionally allowed "linary"
and "luffer" as alternatives for "binary" and "buffer".

Regression introduced in commit 54cc721 ("buffer: introduce latin1
encoding term".)

PR-URL: nodejs#7262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 13, 2016
    Configuration menu
    Copy the full SHA
    6b48324 View commit details
    Browse the repository at this point in the history