Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-vm-timeout flaky on windows #7359

Closed
wants to merge 1 commit into from
Closed

test: mark test-vm-timeout flaky on windows #7359

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 22, 2016

Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test vm

Description of change

Refs: #6727

/cc @nodejs/testing

@Trott Trott added vm Issues and PRs related to the vm subsystem. test Issues and PRs related to the tests. labels Jun 22, 2016
@mscdex
Copy link
Contributor

mscdex commented Jun 22, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Jun 22, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/3048/

@santigimeno
Copy link
Member

Looks like it didn't work: https://ci.nodejs.org/job/node-test-binary-windows/RUN_SUBSET=3,VS_VERSION=vs2015,label=win10/2579/console

@joaocgreis
Copy link
Member

LGTM

@santigimeno the half-transparent circles (green,red,...) are links to jobs that were run before but not on that specific job. Two days ago I had run a job on all possible windows combinations, but was not able to delete it after, and your link points to it. (I was able to delete it today using another method)

@santigimeno
Copy link
Member

@joaocgreis sorry, I didn't know that. Thanks for pointing that out.

LGTM then.

Trott added a commit to Trott/io.js that referenced this pull request Jun 22, 2016
@Trott
test: mark test-vm-timeout flaky on windows
f34caa9 
PR-URL: nodejs#7359
Refs: nodejs#6727
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 22, 2016

Landed in f34caa9

@Trott Trott closed this Jun 22, 2016
@addaleax addaleax mentioned this pull request Jun 22, 2016
Closed
3 tasks
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
@Trott @Fishrock123
test: mark test-vm-timeout flaky on windows
5e48925 
PR-URL: #7359
Refs: #6727
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
@Trott @Fishrock123
test: mark test-vm-timeout flaky on windows
c236a13 
PR-URL: #7359
Refs: #6727
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@Trott
test: mark test-vm-timeout flaky on windows
46b0d90 
PR-URL: #7359
Refs: #6727
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott @MylesBorins
test: mark test-vm-timeout flaky on windows
a27cbec 
PR-URL: #7359
Refs: #6727
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
test: mark test-vm-timeout flaky on windows
640a3aa 
PR-URL: #7359
Refs: #6727
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
test: mark test-vm-timeout flaky on windows
335a90b 
PR-URL: #7359
Refs: #6727
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
test: mark test-vm-timeout flaky on windows
5129f3f 
PR-URL: #7359
Refs: #6727
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Trott Trott deleted the vm-flaky branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @mscdex @santigimeno @joaocgreis @MylesBorins