Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: tab completion for defined commands #7364

Closed
wants to merge 1 commit into from
Closed

repl: tab completion for defined commands #7364

wants to merge 1 commit into from

Conversation

princejwesley
Copy link
Contributor

Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

repl

Description of change

Tab completion is not working for REPL defined commands

> .<<TAB>>
break  clear  exit   help   load   save

>.b<<TAB>>  // no tab completion

@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Jun 22, 2016
@Fishrock123 Fishrock123 added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 24, 2016
@Fishrock123
Copy link
Contributor

LGTM, CI: https://ci.nodejs.org/job/node-test-pull-request/3065/

@Fishrock123 Fishrock123 self-assigned this Jun 24, 2016
@addaleax
Copy link
Member

LGTM

@Fishrock123 Fishrock123 removed the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 27, 2016
@Fishrock123
Copy link
Contributor

Fishrock123 commented Jun 27, 2016 •
edited
Loading

Thanks, landed in 9d56c40!

Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
@princejwesley @Fishrock123
repl: fix tab completion for defined commands
9d56c40 
PR-URL: #7364
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
@princejwesley @Fishrock123
repl: fix tab completion for defined commands
e4db716 
PR-URL: #7364
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
@princejwesley @Fishrock123
repl: fix tab completion for defined commands
ca95a84 
PR-URL: #7364
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@princejwesley
repl: fix tab completion for defined commands
d8c9f4c 
PR-URL: #7364
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@princejwesley @MylesBorins
repl: fix tab completion for defined commands
73cdc54 
PR-URL: #7364
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@princejwesley
repl: fix tab completion for defined commands
e9585d2 
PR-URL: #7364
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@princejwesley
repl: fix tab completion for defined commands
7fd1f1a 
PR-URL: #7364
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@princejwesley
repl: fix tab completion for defined commands
e626c3c 
PR-URL: #7364
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@princejwesley
repl: fix tab completion for defined commands
c8e9adb 
PR-URL: #7364
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Fishrock123 Fishrock123

Labels
repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@princejwesley @Fishrock123 @addaleax @MylesBorins @nodejs-github-bot