-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update v8_inspector #7385
Conversation
Pick up latest commit of v8_inspector and inspector_protocol. This brings back compatibility with V8 5.1.
LGTM |
Some questions/notes:
|
|
|
@mscdex I marked it dont-land-on-v6.x because the original pr has not landed on v6.x and it makes it easier to reason about commits to cherry-pick for releases. That being said, I am pushing for the next v6.x release to include it and would then remove the label. |
@ofrobots thanks. Maybe you could help with https://codereview.chromium.org/2084343002/. The buildbot didn't use the email address I want. |
landed in ecd639a |
Pick up latest commit of v8_inspector and inspector_protocol. This brings back compatibility with V8 5.1. PR-URL: #7385 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Pick up latest commit of v8_inspector and inspector_protocol. This brings back compatibility with V8 5.1. PR-URL: #7385 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Checklist
make -j4 test
(UNIX) orvcbuild test nosign
(Windows) passesDescription of change
Pick up latest commit of v8_inspector and inspector_protocol.
This brings back compatibility with V8 5.1.
R= @ofrobots