Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add lxe as collaborator #745

Closed
wants to merge 1 commit into from
Closed

doc: add lxe as collaborator #745

wants to merge 1 commit into from

Conversation

lxe
Copy link

@lxe lxe commented Feb 6, 2015

@cjihrig
Copy link
Contributor

cjihrig commented Feb 6, 2015

LGTM

lxe pushed a commit that referenced this pull request Feb 6, 2015
doc: add lxe as collaborator
96597bc 
PR-URL: #745
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@lxe
Copy link
Author

lxe commented Feb 6, 2015

Closed by 96597bc

If anyone knows a trick to amend a mainline commit, without touching the PR branch, and close the PR with that commit, that would be awesome.

@lxe lxe closed this Feb 6, 2015
@targos
Copy link
Member

targos commented Feb 6, 2015

I guess this help article applies

@bnoordhuis
Copy link
Member

@lxe git commit --amend && git push your-repo +HEAD:your-branch && git push origin v1.x && git push your-repo :your-branch

@rvagg rvagg mentioned this pull request Feb 10, 2015
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lxe @cjihrig @targos @bnoordhuis