Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cpplint #7462

Merged
merged 22 commits into from
Jun 29, 2016
Merged

Upgrade cpplint #7462

merged 22 commits into from
Jun 29, 2016

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Jun 28, 2016 •
edited
Loading

Fixes #7444.

I dropped our custom whitespace/if-one-line rule because I don't think it's all that great and didn't feel like reimplementing it.

R=@trevnorris?

CI: https://ci.nodejs.org/job/node-test-pull-request/3109/

@bnoordhuis
tools: update cpplint to r456
04c723d 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
tools: disable unwanted cpplint rules again
fc10624 
This commit disables the build/include, build/include_alpha,
build/include_order and legal/copyright warnings again.

PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
tools: add back --mode=tap to cpplint
bb81d69 
This commit reimplements commit 7b45163 ("tools: add tap output to
cpplint") on top of the upgraded copy of cpplint.

PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
tools: allow cpplint to run outside git repo
fadf66a 
This reapplies commit a493dab ("cpplint: make it possible to run
outside git repo") from September 2015, this time with a proper
status line.

PR-URL: nodejs#7462
Refs: nodejs#2693
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix build/c++tr1 cpplint warnings
19ec5d7 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix build/header_guard cpplint warnings
e9559d0 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix readability/braces cpplint warnings
29228c4 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix readability/constructors cpplint warnings
df3a192 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix readability/inheritance cpplint warnings
8e39522 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix readability/namespace cpplint warnings
0ba0eca 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix readability/nolint cpplint warnings
d112df4 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix runtime/indentation_namespace warnings
1243134 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix runtime/int cpplint warnings
ae0c650 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix runtime/references cpplint warnings
2f2002a 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix whitespace/blank_line cpplint warnings
0daffdf 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: fix whitespace/indent cpplint warnings
97aeb0a 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
build: remove unused files from CPPLINT_FILES
f52e26f 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: lint node_win32_perfctr_provider.cc
a26c3cd 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: lint node_lttng_tp.h
f1d2792 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: lint v8abbr.h
dbe4b58 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
tools: fix -Wunused-variable warning
9a6439a 
PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
src: remove obsolete NOLINT comments
f8d3f6f 
Obsoleted by the recent cpplint upgrade.

PR-URL: nodejs#7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis bnoordhuis added c++ Issues and PRs that require attention from people who are familiar with C++. build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 28, 2016
@nodejs-github-bot nodejs-github-bot added the inspector Issues and PRs related to the V8 inspector protocol label Jun 28, 2016
@bnoordhuis bnoordhuis mentioned this pull request Jun 28, 2016
Closed
@mscdex mscdex removed the inspector Issues and PRs related to the V8 inspector protocol label Jun 28, 2016
trevnorris
trevnorris reviewed Jun 28, 2016
View reviewed changes
src/node_version.h
@@ -51,4 +51,4 @@
*/
#define NODE_MODULE_VERSION 48 /* Node.js v6.0.0 */

#endif /* SRC_NODE_VERSION_H_ */
#endif // SRC_NODE_VERSION_H_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh. this rule was the first thing I spent time fixing on my initial attempt. wish I had taken the time to see how many lines of code were affected first.

MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
build: remove unused files from CPPLINT_FILES
f40f882 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: lint node_win32_perfctr_provider.cc
5daf07e 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: lint node_lttng_tp.h
59575b1 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: lint v8abbr.h
f9e835c 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
tools: fix -Wunused-variable warning
93c68a1 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: remove obsolete NOLINT comments
e84388b 
Obsoleted by the recent cpplint upgrade.

PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
tools: update cpplint to r456
391fc80 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
tools: disable unwanted cpplint rules again
e74f199 
This commit disables the build/include, build/include_alpha,
build/include_order and legal/copyright warnings again.

PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
tools: add back --mode=tap to cpplint
09e98a4 
This commit reimplements commit 7b45163 ("tools: add tap output to
cpplint") on top of the upgraded copy of cpplint.

PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
tools: allow cpplint to run outside git repo
4a2bd2d 
This reapplies commit a493dab ("cpplint: make it possible to run
outside git repo") from September 2015, this time with a proper
status line.

PR-URL: #7462
Refs: #2693
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix build/c++tr1 cpplint warnings
ccc701e 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix build/header_guard cpplint warnings
c8f78a2 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix readability/braces cpplint warnings
16f2497 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix readability/constructors cpplint warnings
c90ae7f 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix readability/inheritance cpplint warnings
7852117 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix readability/namespace cpplint warnings
4748bed 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix readability/nolint cpplint warnings
68db091 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix runtime/indentation_namespace warnings
d6595ad 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix runtime/int cpplint warnings
f530a36 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix runtime/references cpplint warnings
44cbe03 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix whitespace/blank_line cpplint warnings
066064d 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: fix whitespace/indent cpplint warnings
4f4d3e7 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
build: remove unused files from CPPLINT_FILES
0db3aa9 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: lint node_win32_perfctr_provider.cc
27c2d25 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: lint node_lttng_tp.h
42e7c9d 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: lint v8abbr.h
5aff60e 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
tools: fix -Wunused-variable warning
68e9fd4 
PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
src: remove obsolete NOLINT comments
23797eb 
Obsoleted by the recent cpplint upgrade.

PR-URL: #7462
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@joshgav joshgav mentioned this pull request Nov 1, 2016
Closed
2 tasks
@cclauss cclauss mentioned this pull request Jan 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bnoordhuis @trevnorris @Fishrock123 @addaleax @MylesBorins @mscdex @nodejs-github-bot