-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: fix V8 5.1 tests #7488
deps: fix V8 5.1 tests #7488
Conversation
Restore whitespaces in *.golden files. They were lost when I landed the V8 5.1 update. Fixes: nodejs#7477
WOW. Whitespace causing this pain is pretty wonderful. ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/165/ |
😢 As mentioned in another thread recently, we should really consider landing deps changes without |
benchmark is green. I'm +1 on revisiting whitespace-fix for dependnecies... thoughts @nodejs/ctc? |
I think I agree. |
LGTM |
Restore whitespaces in *.golden files. They were lost when I landed the V8 5.1 update and are needed for the tests to pass. Fixes: nodejs#7477 PR-URL: nodejs#7488 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
landed in dc17432 |
Please add the relevant label(s) for master-only commits. Thanks. |
Checklist
make test-v8
passesAffected core subsystem(s)
v8
Description of change
Restore whitespaces in *.golden files. They were lost when I landed the
V8 5.1 update.
Fixes: #7477