Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errorMessage: Improvement in the error thrown in case of writable st… #7671

Closed
wants to merge 3 commits into from
Closed
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/_stream_writable.js
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ function validChunk(stream, state, chunk, cb) {
}

Writable.prototype.write = function(chunk, encoding, cb) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line also.

var state = this._writableState;
var ret = false;

Expand Down Expand Up @@ -305,6 +306,7 @@ function doWrite(stream, state, writev, len, chunk, encoding, cb) {
stream._writev(chunk, state.onwrite);
else
stream._write(chunk, encoding, state.onwrite);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line.

state.sync = false;
}

Expand Down Expand Up @@ -432,7 +434,7 @@ function clearBuffer(stream, state) {
}

Writable.prototype._write = function(chunk, encoding, cb) {
cb(new Error('not implemented'));
cb(new Error('Write method cannot be invoked on the Writable stream . Method not implemented'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be as simple as _write() must be implemented or _write() is not implemented.

};

Writable.prototype._writev = null;
Expand Down