Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve error message in test-tick-processor #7693

Closed
wants to merge 2 commits into from
Closed

test: improve error message in test-tick-processor #7693

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6707bd
test: improve error message in test-tick-processor
Trott Jul 12, 2016
924249c
squash: typo fix
Trott Jul 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/parallel/test-tick-processor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';
var fs = require('fs');
var assert = require('assert');
var cp = require('child_process');
var common = require('../common');
const fs = require('fs');
const assert = require('assert');
const cp = require('child_process');
const common = require('../common');

// TODO(mhdawson) Currently the test-tick-processor functionality in V8
// depends on addresses being smaller than a full 64 bits. Aix supports
Expand Down Expand Up @@ -49,12 +49,12 @@ function runTest(pattern, code) {
return /^isolate-/.test(file);
});
if (matches.length != 1) {
assert.fail(null, null, 'There should be a single log file.');
common.fail('There should be a single log file.');
}
var log = matches[0];
var out = cp.execSync(process.execPath +
' --prof-process --call-graph-size=10 ' + log,
{encoding: 'utf8'});
assert(pattern.test(out));
assert(pattern.test(out), `${pattern} not matchint ${out}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matching?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matching?

Whoops, yes, fixed.

fs.unlinkSync(log);
}